diff options
author | jochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-14 16:56:21 +0000 |
---|---|---|
committer | jochen@chromium.org <jochen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-14 16:56:21 +0000 |
commit | d49f095a3a882e0d93a1b04f8e7632bce0b6a600 (patch) | |
tree | a9cc206dab02cbaf9677f78774e1244b2024b871 /content/browser/dom_storage | |
parent | 69f885e7f6b0fadaeb2f31faaee9d461e917adb8 (diff) | |
download | chromium_src-d49f095a3a882e0d93a1b04f8e7632bce0b6a600.zip chromium_src-d49f095a3a882e0d93a1b04f8e7632bce0b6a600.tar.gz chromium_src-d49f095a3a882e0d93a1b04f8e7632bce0b6a600.tar.bz2 |
Undo band-aid which was ignoring wrong SessionStorage association
The baind-aid was r143761. Now that crbug.com/138152 and
crbug.com/269449 are fixed, we can hopefully do without.
BUG=269449
R=marja@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23184002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217570 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/dom_storage')
-rw-r--r-- | content/browser/dom_storage/dom_storage_host.cc | 24 |
1 files changed, 6 insertions, 18 deletions
diff --git a/content/browser/dom_storage/dom_storage_host.cc b/content/browser/dom_storage/dom_storage_host.cc index 296d52e..14d288d 100644 --- a/content/browser/dom_storage/dom_storage_host.cc +++ b/content/browser/dom_storage/dom_storage_host.cc @@ -30,12 +30,8 @@ bool DOMStorageHost::OpenStorageArea(int connection_id, int namespace_id, return false; // Indicates the renderer gave us very bad data. NamespaceAndArea references; references.namespace_ = context_->GetStorageNamespace(namespace_id); - if (!references.namespace_.get()) { - // TODO(michaeln): Fix crbug/134003 and return false here. - // Until then return true to avoid crashing the renderer for - // sending a bad message. - return true; - } + if (!references.namespace_.get()) + return false; references.area_ = references.namespace_->OpenStorageArea(origin); DCHECK(references.area_.get()); connections_[connection_id] = references; @@ -54,12 +50,8 @@ bool DOMStorageHost::ExtractAreaValues( int connection_id, DOMStorageValuesMap* map) { map->clear(); DOMStorageArea* area = GetOpenArea(connection_id); - if (!area) { - // TODO(michaeln): Fix crbug/134003 and return false here. - // Until then return true to avoid crashing the renderer - // for sending a bad message. - return true; - } + if (!area) + return false; if (!area->IsLoadedInMemory()) { DOMStorageNamespace* ns = GetNamespace(connection_id); DCHECK(ns); @@ -101,12 +93,8 @@ bool DOMStorageHost::SetAreaItem( const base::string16& value, const GURL& page_url, base::NullableString16* old_value) { DOMStorageArea* area = GetOpenArea(connection_id); - if (!area) { - // TODO(michaeln): Fix crbug/134003 and return false here. - // Until then return true to allow the renderer to operate - // to a limited degree out of its cache. - return true; - } + if (!area) + return false; if (!area->SetItem(key, value, old_value)) return false; if (old_value->is_null() || old_value->string() != value) |