Rewrite std::string("") to std::string(), Linux edition.

This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.

BUG=none

Review URL: https://codereview.chromium.org/13145003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 8 insertions, 8 deletions

diff --git a/content/browser/download/base_file_unittest.cc b/content/browser/download/base_file_unittest.cc
index 799076d..0e6239f 100644
--- a/content/browser/download/base_file_unittest.cc
+++ b/content/browser/download/base_file_unittest.cc
@@ -54,7 +54,7 @@ class BaseFileTest : public testing::Test {
                                   GURL(),
                                   0,
                                   false,
-                                  "",
+                                  std::string(),
                                   scoped_ptr<net::FileStream>(),
                                   net::BoundNetLog()));
   }
@@ -105,7 +105,7 @@ class BaseFileTest : public testing::Test {
                                   GURL(),
                                   0,
                                   true,
-                                  "",
+                                  std::string(),
                                   scoped_ptr<net::FileStream>(),
                                   net::BoundNetLog()));
   }
@@ -145,7 +145,7 @@ class BaseFileTest : public testing::Test {
                   GURL(),
                   0,
                   false,
-                  "",
+                  std::string(),
                   scoped_ptr<net::FileStream>(),
                   net::BoundNetLog());
 
@@ -171,7 +171,7 @@ class BaseFileTest : public testing::Test {
                             GURL(),
                             0,
                             false,
-                            "",
+                            std::string(),
                             scoped_ptr<net::FileStream>(),
                             net::BoundNetLog());
     EXPECT_EQ(DOWNLOAD_INTERRUPT_REASON_NONE,
@@ -503,7 +503,7 @@ TEST_F(BaseFileTest, MultipleWritesWithError) {
                                 GURL(),
                                 0,
                                 false,
-                                "",
+                                std::string(),
                                 mock_file_stream_scoped_ptr.Pass(),
                                 net::BoundNetLog()));
   ASSERT_TRUE(InitializeFile());
@@ -550,7 +550,7 @@ TEST_F(BaseFileTest, AppendToBaseFile) {
                                 GURL(),
                                 kTestDataLength4,
                                 false,
-                                "",
+                                std::string(),
                                 scoped_ptr<net::FileStream>(),
                                 net::BoundNetLog()));
 
@@ -584,7 +584,7 @@ TEST_F(BaseFileTest, ReadonlyBaseFile) {
                                 GURL(),
                                 0,
                                 false,
-                                "",
+                                std::string(),
                                 scoped_ptr<net::FileStream>(),
                                 net::BoundNetLog()));
 
@@ -609,7 +609,7 @@ TEST_F(BaseFileTest, IsEmptyHash) {
   EXPECT_TRUE(BaseFile::IsEmptyHash(empty));
   std::string not_empty(BaseFile::kSha256HashLen, '\x01');
   EXPECT_FALSE(BaseFile::IsEmptyHash(not_empty));
-  EXPECT_FALSE(BaseFile::IsEmptyHash(""));
+  EXPECT_FALSE(BaseFile::IsEmptyHash(std::string()));
 }
 
 // Test that calculating speed after no writes.