diff options
| author | benwells@chromium.org <benwells@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-08 00:06:23 +0000 |
|---|---|---|
| committer | benwells@chromium.org <benwells@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-08 00:06:23 +0000 |
| commit | d96ee58230265ed1c61a1e728caee735e5564d40 (patch) | |
| tree | e235e30deb46dc1cec878c80401c16321ee05a68 /content/browser/download/download_item.h | |
| parent | db2b146b7fcbc7ba59c9dd0c469b34e67caa93ae (diff) | |
| download | chromium_src-d96ee58230265ed1c61a1e728caee735e5564d40.zip chromium_src-d96ee58230265ed1c61a1e728caee735e5564d40.tar.gz chromium_src-d96ee58230265ed1c61a1e728caee735e5564d40.tar.bz2 | |
Removed progress timer from DownloadItem
This timer is redundant - all state changes which need to be updated immediately
call UpdateObservers directly, and there is already a central timer in the
download file manager which updates progress.
Testing has been done manually to ensure the download shelf and the downloads UI
get updated properly when downloading items. Also unit testing has been added
for DownloadItem's public interface to check that state-changing functions
generate notifications.
BUG=None
TEST=See above.
Review URL: http://codereview.chromium.org/8463003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108947 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/download/download_item.h')
| -rw-r--r-- | content/browser/download/download_item.h | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/content/browser/download/download_item.h b/content/browser/download/download_item.h index 24a367f..14f873a 100644 --- a/content/browser/download/download_item.h +++ b/content/browser/download/download_item.h @@ -25,7 +25,6 @@ #include "base/memory/scoped_ptr.h" #include "base/observer_list.h" #include "base/time.h" -#include "base/timer.h" #include "content/browser/download/download_id.h" #include "content/browser/download/download_request_handle.h" #include "content/browser/download/download_state_info.h" @@ -359,10 +358,6 @@ class CONTENT_EXPORT DownloadItem { // is completed. void Completed(); - // Start/stop sending periodic updates to our observers - void StartProgressTimer(); - void StopProgressTimer(); - // Call to transition state; all state transitions should go through this. void TransitionTo(DownloadState new_state); @@ -445,9 +440,6 @@ class CONTENT_EXPORT DownloadItem { // Our persistent store handle int64 db_handle_; - // Timer for regularly updating our observers - base::RepeatingTimer<DownloadItem> update_timer_; - // Our owning object DownloadManager* download_manager_; |