diff options
| author | rdsmith@chromium.org <rdsmith@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-19 14:53:00 +0000 |
|---|---|---|
| committer | rdsmith@chromium.org <rdsmith@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-19 14:53:00 +0000 |
| commit | e2c1a644a1be1b3e0a99148ee3590b6da506d86e (patch) | |
| tree | 59a8b98bf0cf48cb8229d00cd98021622b6700e7 /content/browser/download/download_item_impl_delegate.h | |
| parent | 34df2abd18b58f0a0b41fc67237a2f33c75e91b2 (diff) | |
| download | chromium_src-e2c1a644a1be1b3e0a99148ee3590b6da506d86e.zip chromium_src-e2c1a644a1be1b3e0a99148ee3590b6da506d86e.tar.gz chromium_src-e2c1a644a1be1b3e0a99148ee3590b6da506d86e.tar.bz2 | |
Revert 152213 - Replace the DownloadFileManager with direct ownership of DownloadFile.
This CL is a re-land of http://codereview.chromium.org/10799005, which
was reverted due to test flakiness.
BUG=123998
R=benjhayden@chromium.org
TBR=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10836293
BUG=143600
TBR=rdsmith@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10861002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152282 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/download/download_item_impl_delegate.h')
| -rw-r--r-- | content/browser/download/download_item_impl_delegate.h | 14 |
1 files changed, 2 insertions, 12 deletions
diff --git a/content/browser/download/download_item_impl_delegate.h b/content/browser/download/download_item_impl_delegate.h index a2f2db2..0092454 100644 --- a/content/browser/download/download_item_impl_delegate.h +++ b/content/browser/download/download_item_impl_delegate.h @@ -28,23 +28,13 @@ class CONTENT_EXPORT DownloadItemImplDelegate { void Attach(); void Detach(); - // Start the delegate's portion of the download; called when the - // download item is ready for the delegate to take over. - // Pure virtual because if the delegate doesn't do something the - // DownloadItemImpl is dead in the water. - // TODO(rdsmith): The machinery of running the download should be - // moved into the DownloadItem, and this should be changed into - // a probe as to whether to start and if not, provide a callback - // to call when it's time to start. - virtual void DelegateStart(DownloadItemImpl* download) = 0; + // Tests if a file type should be opened automatically. + virtual bool ShouldOpenFileBasedOnExtension(const FilePath& path); // Allows the delegate to override the opening of a download. If it returns // true then it's reponsible for opening the item. virtual bool ShouldOpenDownload(DownloadItemImpl* download); - // Tests if a file type should be opened automatically. - virtual bool ShouldOpenFileBasedOnExtension(const FilePath& path); - // Checks whether a downloaded file still exists and updates the // file's state if the file is already removed. // The check may or may not result in a later asynchronous call |