diff options
| author | rdsmith@chromium.org <rdsmith@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-24 17:01:21 +0000 |
|---|---|---|
| committer | rdsmith@chromium.org <rdsmith@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-24 17:01:21 +0000 |
| commit | ee26796967de038f855e7260e3e10b8a7bae6c15 (patch) | |
| tree | fccf63d0226b684b8f99b313df00cb1a9e8e8224 /content/browser/download/download_item_impl_delegate.h | |
| parent | 658f9ca69a0c2187948618b55a9453068052838d (diff) | |
| download | chromium_src-ee26796967de038f855e7260e3e10b8a7bae6c15.zip chromium_src-ee26796967de038f855e7260e3e10b8a7bae6c15.tar.gz chromium_src-ee26796967de038f855e7260e3e10b8a7bae6c15.tar.bz2 | |
Revert 153221 - Remove DownloadFileManager in favor of direct ownership of DownloadFiles.
This CL is equivalent to CLs http://codereview.chromium.org/10799005 and
http://codereview.chromium.org/10836293, which were previous attempts
to land the same functionality.
TBR=jam@chromium.org
BUG=123998
Review URL: https://chromiumcodereview.appspot.com/10823406
TBR=rdsmith@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10878054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153229 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/download/download_item_impl_delegate.h')
| -rw-r--r-- | content/browser/download/download_item_impl_delegate.h | 14 |
1 files changed, 2 insertions, 12 deletions
diff --git a/content/browser/download/download_item_impl_delegate.h b/content/browser/download/download_item_impl_delegate.h index a2f2db2..0092454 100644 --- a/content/browser/download/download_item_impl_delegate.h +++ b/content/browser/download/download_item_impl_delegate.h @@ -28,23 +28,13 @@ class CONTENT_EXPORT DownloadItemImplDelegate { void Attach(); void Detach(); - // Start the delegate's portion of the download; called when the - // download item is ready for the delegate to take over. - // Pure virtual because if the delegate doesn't do something the - // DownloadItemImpl is dead in the water. - // TODO(rdsmith): The machinery of running the download should be - // moved into the DownloadItem, and this should be changed into - // a probe as to whether to start and if not, provide a callback - // to call when it's time to start. - virtual void DelegateStart(DownloadItemImpl* download) = 0; + // Tests if a file type should be opened automatically. + virtual bool ShouldOpenFileBasedOnExtension(const FilePath& path); // Allows the delegate to override the opening of a download. If it returns // true then it's reponsible for opening the item. virtual bool ShouldOpenDownload(DownloadItemImpl* download); - // Tests if a file type should be opened automatically. - virtual bool ShouldOpenFileBasedOnExtension(const FilePath& path); - // Checks whether a downloaded file still exists and updates the // file's state if the file is already removed. // The check may or may not result in a later asynchronous call |