summaryrefslogtreecommitdiffstats
path: root/content/browser/download
diff options
context:
space:
mode:
authormichaeln@chromium.org <michaeln@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-12-20 07:46:09 +0000
committermichaeln@chromium.org <michaeln@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-12-20 07:46:09 +0000
commit55e37a9d1d0705d17b3b10aa18a17e3c82387b5c (patch)
treed551b874e91a8cf26f0541740115b236d0b15df7 /content/browser/download
parente3058a43216e38485c1f6a7f0bcc5a1f0a25528f (diff)
downloadchromium_src-55e37a9d1d0705d17b3b10aa18a17e3c82387b5c.zip
chromium_src-55e37a9d1d0705d17b3b10aa18a17e3c82387b5c.tar.gz
chromium_src-55e37a9d1d0705d17b3b10aa18a17e3c82387b5c.tar.bz2
Minor cleanup: make a method pure virtual
BUG=98443 Review URL: https://chromiumcodereview.appspot.com/11645004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174110 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/download')
-rw-r--r--content/browser/download/download_resource_handler.cc6
-rw-r--r--content/browser/download/download_resource_handler.h3
-rw-r--r--content/browser/download/save_file_resource_handler.cc6
-rw-r--r--content/browser/download/save_file_resource_handler.h3
4 files changed, 18 insertions, 0 deletions
diff --git a/content/browser/download/download_resource_handler.cc b/content/browser/download/download_resource_handler.cc
index 4498c98..d7e7a68 100644
--- a/content/browser/download/download_resource_handler.cc
+++ b/content/browser/download/download_resource_handler.cc
@@ -367,6 +367,12 @@ bool DownloadResourceHandler::OnResponseCompleted(
return true;
}
+void DownloadResourceHandler::OnDataDownloaded(
+ int request_id,
+ int bytes_downloaded) {
+ NOTREACHED();
+}
+
// If the content-length header is not present (or contains something other
// than numbers), the incoming content_length is -1 (unknown size).
// Set the content length to 0 to indicate unknown size to DownloadManager.
diff --git a/content/browser/download/download_resource_handler.h b/content/browser/download/download_resource_handler.h
index fc3e029..f409964 100644
--- a/content/browser/download/download_resource_handler.h
+++ b/content/browser/download/download_resource_handler.h
@@ -76,6 +76,9 @@ class DownloadResourceHandler
const net::URLRequestStatus& status,
const std::string& security_info) OVERRIDE;
+ // N/A to this flavor of DownloadHandler.
+ virtual void OnDataDownloaded(int request_id, int bytes_downloaded) OVERRIDE;
+
void PauseRequest();
void ResumeRequest();
void CancelRequest();
diff --git a/content/browser/download/save_file_resource_handler.cc b/content/browser/download/save_file_resource_handler.cc
index e2f2b89..d611040 100644
--- a/content/browser/download/save_file_resource_handler.cc
+++ b/content/browser/download/save_file_resource_handler.cc
@@ -109,6 +109,12 @@ bool SaveFileResourceHandler::OnResponseCompleted(
return true;
}
+void SaveFileResourceHandler::OnDataDownloaded(
+ int request_id,
+ int bytes_downloaded) {
+ NOTREACHED();
+}
+
void SaveFileResourceHandler::set_content_length(
const std::string& content_length) {
base::StringToInt64(content_length, &content_length_);
diff --git a/content/browser/download/save_file_resource_handler.h b/content/browser/download/save_file_resource_handler.h
index 07e24ba..8f77f5b 100644
--- a/content/browser/download/save_file_resource_handler.h
+++ b/content/browser/download/save_file_resource_handler.h
@@ -59,6 +59,9 @@ class SaveFileResourceHandler : public ResourceHandler {
const net::URLRequestStatus& status,
const std::string& security_info) OVERRIDE;
+ // N/A to this flavor of SaveFileResourceHandler.
+ virtual void OnDataDownloaded(int request_id, int bytes_downloaded) OVERRIDE;
+
// If the content-length header is not present (or contains something other
// than numbers), StringToInt64 returns 0, which indicates 'unknown size' and
// is handled correctly by the SaveManager.