diff options
author | clamy@chromium.org <clamy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-28 01:52:24 +0000 |
---|---|---|
committer | clamy@chromium.org <clamy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-28 01:52:24 +0000 |
commit | 21b41c7e89c864e8bd5da8e4f81c38043eba83c5 (patch) | |
tree | 7be7e64a9a8e63ea75984ce7799ac615c0b1196b /content/browser/frame_host/frame_tree.h | |
parent | 82590814af33f91394e590df8a2b14c208563989 (diff) | |
download | chromium_src-21b41c7e89c864e8bd5da8e4f81c38043eba83c5.zip chromium_src-21b41c7e89c864e8bd5da8e4f81c38043eba83c5.tar.gz chromium_src-21b41c7e89c864e8bd5da8e4f81c38043eba83c5.tar.bz2 |
Revert "Revert 249676 "Have the unload event execute in background on cr...""
This fixes a bug in the original CL which may have caused a crash in
ProfileDestroyer.
BUG=343002,323528,342361
Review URL: https://codereview.chromium.org/180993003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254007 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/frame_host/frame_tree.h')
-rw-r--r-- | content/browser/frame_host/frame_tree.h | 20 |
1 files changed, 14 insertions, 6 deletions
diff --git a/content/browser/frame_host/frame_tree.h b/content/browser/frame_host/frame_tree.h index 8e18956..1a43618 100644 --- a/content/browser/frame_host/frame_tree.h +++ b/content/browser/frame_host/frame_tree.h @@ -116,8 +116,8 @@ class CONTENT_EXPORT FrameTree { void UnregisterRenderFrameHost(RenderFrameHostImpl* render_frame_host); private: - typedef std::pair<RenderViewHostImpl*, int> RenderViewHostRefCount; - typedef base::hash_map<int, RenderViewHostRefCount> RenderViewHostMap; + typedef base::hash_map<int, RenderViewHostImpl*> RenderViewHostMap; + typedef std::multimap<int, RenderViewHostImpl*> RenderViewHostMultiMap; // These delegates are installed into all the RenderViewHosts and // RenderFrameHosts that we create. @@ -126,15 +126,23 @@ class CONTENT_EXPORT FrameTree { RenderWidgetHostDelegate* render_widget_delegate_; RenderFrameHostManager::Delegate* manager_delegate_; - // Map of SiteInstance ID to a (RenderViewHost, refcount) pair. This allows - // us to look up the RenderViewHost for a given SiteInstance when creating - // RenderFrameHosts, and it allows us to call Shutdown on the RenderViewHost - // and remove it from the map when no more RenderFrameHosts are using it. + // Map of SiteInstance ID to a RenderViewHost. This allows us to look up the + // RenderViewHost for a given SiteInstance when creating RenderFrameHosts. + // Combined with the refcount on RenderViewHost, this allows us to call + // Shutdown on the RenderViewHost and remove it from the map when no more + // RenderFrameHosts are using it. // // Must be declared before |root_| so that it is deleted afterward. Otherwise // the map will be cleared before we delete the RenderFrameHosts in the tree. RenderViewHostMap render_view_host_map_; + // Map of SiteInstance ID to RenderViewHosts that are pending shutdown. The + // renderers of these RVH are currently executing the unload event in + // background. When the SwapOutACK is received, they will be deleted. In the + // meantime, they are kept in this map, as they should not be reused (part of + // their state is already gone away). + RenderViewHostMultiMap render_view_host_pending_shutdown_map_; + scoped_ptr<FrameTreeNode> root_; base::Callback<void(RenderViewHostImpl*, int)> on_frame_removed_; |