summaryrefslogtreecommitdiffstats
path: root/content/browser/indexed_db/leveldb/leveldb_database.h
diff options
context:
space:
mode:
authorthestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-06-06 04:46:21 +0000
committerthestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-06-06 04:46:21 +0000
commit6af604b48fc3f0f5ff5e7ef2e8951b16833acf60 (patch)
tree4d2605b6da5b777e8ad8cdeac9c6e4d6d5a03d13 /content/browser/indexed_db/leveldb/leveldb_database.h
parent158cdc931a3537cb881000829c8bff37b6574c51 (diff)
downloadchromium_src-6af604b48fc3f0f5ff5e7ef2e8951b16833acf60.zip
chromium_src-6af604b48fc3f0f5ff5e7ef2e8951b16833acf60.tar.gz
chromium_src-6af604b48fc3f0f5ff5e7ef2e8951b16833acf60.tar.bz2
Revert 204391 "IndexedDB: Convert decoding functions to pass Str..."
> IndexedDB: Convert decoding functions to pass StringPieces vs. pointers > > The ugly decoding functions that do pointer arithmetic were nasty in > the Blink codebase. Conversion to Chromium and replacing WTF::Vector > with std::vector made things worse due to iterator differences across > platforms in C++03. Start replacing all that goo with StringPiece > which encapsulates the pointers and is a better match for the "slice" > model of leveldb. > > Also avoids a std::string to std::vector<char> data copy when getting > values - hooray! Standardizes the various DecodeXXX function signatures > to take a mutable slice and always return a success code. > > Key path encode/decode tests were updated to have the "expected" encoded > data in the test rather than manually computing it. > > Left to do: the various Key-type classes still pass around raw pointers, > and LevelDBSlice should be removed entirely in favor of StringPiece. > > BUG=234278 > R=alecflett@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/16256014 TBR=jsbell@chromium.org Review URL: https://codereview.chromium.org/16331006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204417 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/indexed_db/leveldb/leveldb_database.h')
-rw-r--r--content/browser/indexed_db/leveldb/leveldb_database.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/content/browser/indexed_db/leveldb/leveldb_database.h b/content/browser/indexed_db/leveldb/leveldb_database.h
index 952c4b6..0c7427b 100644
--- a/content/browser/indexed_db/leveldb/leveldb_database.h
+++ b/content/browser/indexed_db/leveldb/leveldb_database.h
@@ -51,7 +51,7 @@ class CONTENT_EXPORT LevelDBDatabase {
bool Put(const LevelDBSlice& key, const std::vector<char>& value);
bool Remove(const LevelDBSlice& key);
virtual bool Get(const LevelDBSlice& key,
- std::string* value,
+ std::vector<char>& value,
bool& found,
const LevelDBSnapshot* = 0);
bool Write(LevelDBWriteBatch& batch);