diff options
| author | sergeygs@chromium.org <sergeygs@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-27 14:33:59 +0000 |
|---|---|---|
| committer | sergeygs@chromium.org <sergeygs@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-27 14:33:59 +0000 |
| commit | 7098382b9d525021c59493b63f3cfe4bcb925355 (patch) | |
| tree | b125debbe3319a8287800399c590fdeac4d957ef /content/browser/loader/resource_loader.cc | |
| parent | f1d109f3b735b696cc5e539c8b585e8df2066cc7 (diff) | |
| download | chromium_src-7098382b9d525021c59493b63f3cfe4bcb925355.zip chromium_src-7098382b9d525021c59493b63f3cfe4bcb925355.tar.gz chromium_src-7098382b9d525021c59493b63f3cfe4bcb925355.tar.bz2 | |
Explicitly prevent URL-to-app redirection for forced downloads
There are 2 parts:
1) Replace ResourceRequestInfoImpl::is_download() with virtual ResourceRequestInfo::IsDownload().
2) Use it in app_url_redirector.cpp to explicitly avoid redirection of forced downloads.
@darin: In my testing, forced downloads were fine even without this (apparently, resource throttling is disabled in this case). Let me know if you still think explicit prevention is a good idea (I do think so).
BUG=302904
Review URL: https://codereview.chromium.org/62463004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237570 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/loader/resource_loader.cc')
| -rw-r--r-- | content/browser/loader/resource_loader.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/content/browser/loader/resource_loader.cc b/content/browser/loader/resource_loader.cc index 4993c82..01f95a1 100644 --- a/content/browser/loader/resource_loader.cc +++ b/content/browser/loader/resource_loader.cc @@ -437,7 +437,7 @@ void ResourceLoader::CancelRequestInternal(int error, bool from_renderer) { // WebKit will send us a cancel for downloads since it no longer handles // them. In this case, ignore the cancel since we handle downloads in the // browser. - if (from_renderer && (info->is_download() || info->is_stream())) + if (from_renderer && (info->IsDownload() || info->is_stream())) return; if (from_renderer && info->detachable_handler()) { |