summaryrefslogtreecommitdiffstats
path: root/content/browser/loader/resource_loader_unittest.cc
diff options
context:
space:
mode:
authordavidben@chromium.org <davidben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-05-28 21:55:57 +0000
committerdavidben@chromium.org <davidben@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-05-28 21:55:57 +0000
commitd22e800e2cf8ddc13d4491e9eeec09a93815e7a9 (patch)
treefdbd5c9ab68e20cccd749f4a3bfef40b63790b0c /content/browser/loader/resource_loader_unittest.cc
parent9646057ea365fd0d0ccdde7d4989517d1e56bdd3 (diff)
downloadchromium_src-d22e800e2cf8ddc13d4491e9eeec09a93815e7a9.zip
chromium_src-d22e800e2cf8ddc13d4491e9eeec09a93815e7a9.tar.gz
chromium_src-d22e800e2cf8ddc13d4491e9eeec09a93815e7a9.tar.bz2
Remove request_id parameter from ResourceHandler methods.
AsyncResourceHandler and downloads are the only components which consume it. Everyone else just passes it down. Pull it out of ResourceRequestInfo where needed. Other components need not deal with it. BUG=376003 Review URL: https://codereview.chromium.org/298253006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273368 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/loader/resource_loader_unittest.cc')
-rw-r--r--content/browser/loader/resource_loader_unittest.cc31
1 files changed, 9 insertions, 22 deletions
diff --git a/content/browser/loader/resource_loader_unittest.cc b/content/browser/loader/resource_loader_unittest.cc
index e26184d..d2fdd99 100644
--- a/content/browser/loader/resource_loader_unittest.cc
+++ b/content/browser/loader/resource_loader_unittest.cc
@@ -127,46 +127,37 @@ class ResourceHandlerStub : public ResourceHandler {
}
// ResourceHandler implementation:
- virtual bool OnUploadProgress(int request_id,
- uint64 position,
- uint64 size) OVERRIDE {
+ virtual bool OnUploadProgress(uint64 position, uint64 size) OVERRIDE {
NOTREACHED();
return true;
}
- virtual bool OnRequestRedirected(int request_id,
- const GURL& url,
+ virtual bool OnRequestRedirected(const GURL& url,
ResourceResponse* response,
bool* defer) OVERRIDE {
NOTREACHED();
return true;
}
- virtual bool OnResponseStarted(int request_id,
- ResourceResponse* response,
+ virtual bool OnResponseStarted(ResourceResponse* response,
bool* defer) OVERRIDE {
EXPECT_FALSE(response_);
response_ = response;
return true;
}
- virtual bool OnWillStart(int request_id,
- const GURL& url,
- bool* defer) OVERRIDE {
+ virtual bool OnWillStart(const GURL& url, bool* defer) OVERRIDE {
EXPECT_TRUE(start_url_.is_empty());
start_url_ = url;
*defer = defer_request_on_will_start_;
return true;
}
- virtual bool OnBeforeNetworkStart(int request_id,
- const GURL& url,
- bool* defer) OVERRIDE {
+ virtual bool OnBeforeNetworkStart(const GURL& url, bool* defer) OVERRIDE {
return true;
}
- virtual bool OnWillRead(int request_id,
- scoped_refptr<net::IOBuffer>* buf,
+ virtual bool OnWillRead(scoped_refptr<net::IOBuffer>* buf,
int* buf_size,
int min_size) OVERRIDE {
EXPECT_TRUE(expect_reads_);
@@ -180,9 +171,7 @@ class ResourceHandlerStub : public ResourceHandler {
return true;
}
- virtual bool OnReadCompleted(int request_id,
- int bytes_read,
- bool* defer) OVERRIDE {
+ virtual bool OnReadCompleted(int bytes_read, bool* defer) OVERRIDE {
EXPECT_TRUE(received_on_will_read_);
EXPECT_TRUE(expect_reads_);
EXPECT_FALSE(received_response_completed_);
@@ -201,8 +190,7 @@ class ResourceHandlerStub : public ResourceHandler {
return !cancel_on_read_completed_;
}
- virtual void OnResponseCompleted(int request_id,
- const net::URLRequestStatus& status,
+ virtual void OnResponseCompleted(const net::URLRequestStatus& status,
const std::string& security_info,
bool* defer) OVERRIDE {
EXPECT_FALSE(received_response_completed_);
@@ -213,8 +201,7 @@ class ResourceHandlerStub : public ResourceHandler {
status_ = status;
}
- virtual void OnDataDownloaded(int request_id,
- int bytes_downloaded) OVERRIDE {
+ virtual void OnDataDownloaded(int bytes_downloaded) OVERRIDE {
EXPECT_FALSE(expect_reads_);
total_bytes_downloaded_ += bytes_downloaded;
}