summaryrefslogtreecommitdiffstats
path: root/content/browser/media/webrtc_browsertest.cc
diff options
context:
space:
mode:
authorphoglund@chromium.org <phoglund@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-04-11 14:01:12 +0000
committerphoglund@chromium.org <phoglund@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-04-11 14:01:12 +0000
commitad6068d714ec005db4a448ae55bae99d73cde93a (patch)
tree9e7cdaae8342f58083f25b0c37b5f3efaebcd21c /content/browser/media/webrtc_browsertest.cc
parent5a3a910d8a5d61286917e84afd8d87bb5902e289 (diff)
downloadchromium_src-ad6068d714ec005db4a448ae55bae99d73cde93a.zip
chromium_src-ad6068d714ec005db4a448ae55bae99d73cde93a.tar.gz
chromium_src-ad6068d714ec005db4a448ae55bae99d73cde93a.tar.bz2
Lowering the audio peak treshold a bit after Android flakes.
We got these samples off an Android device just now: "..,15934,15934,15934,15934,15934,15934,3983,3983,3983,83.. ..207,31513,31513,31513,31513,31513,31513,31513,31513,7878,7878,7878, ..21676,21676,21676,21676,21676,21676,5419,5419,5419,5419,5419,1354,.. ..1354,1354,1354,1354,1354,338,338,338,713,713,713,713" There are three peaks in this signal but the 15934 and 21676 is too low to make it over the peak treshold. The problem doesn't seem to be that we sample to little since we get several high values in a row, nor does it seem the sampling is too slow as the affected test took five seconds to execute, which seems about right. I wonder if our stats API is too sluggish on Android so it doesn't record the peaks of the audio signal. Either that, or the audio signal is mangled on Android so it in effect is amplitude reduced. The signal is still pretty clear so I'll just adjust the threshold a bit. We're mostly lookin for completely broken audio here, and this just looks slightly mangled. R=perkj@chromium.org BUG=362432 Review URL: https://codereview.chromium.org/231983007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263237 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/media/webrtc_browsertest.cc')
-rw-r--r--content/browser/media/webrtc_browsertest.cc11
1 files changed, 1 insertions, 10 deletions
diff --git a/content/browser/media/webrtc_browsertest.cc b/content/browser/media/webrtc_browsertest.cc
index 283622b..9f1d522 100644
--- a/content/browser/media/webrtc_browsertest.cc
+++ b/content/browser/media/webrtc_browsertest.cc
@@ -308,17 +308,8 @@ IN_PROC_BROWSER_TEST_P(WebRtcBrowserTest,
MakeTypicalPeerConnectionCall("callAndEnsureAudioIsPlaying();");
}
-#if defined(OS_ANDROID)
-// Flaky on Android: http://crbug.com/362432
-#define MAYBE_EstablishAudioVideoCallAndVerifyMutingWorks \
- FLAKY_EstablishAudioVideoCallAndVerifyMutingWorks
-#else
-#define MAYBE_EstablishAudioVideoCallAndVerifyMutingWorks \
- EstablishAudioVideoCallAndVerifyMutingWorks
-#endif
-
IN_PROC_BROWSER_TEST_P(WebRtcBrowserTest,
- MAYBE_EstablishAudioVideoCallAndVerifyMutingWorks) {
+ EstablishAudioVideoCallAndVerifyMutingWorks) {
if (!media::AudioManager::Get()->HasAudioOutputDevices()) {
// Bots with no output devices will force the audio code into a different
// path where it doesn't manage to set either the low or high latency path.