diff options
author | adamk@google.com <adamk@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-02 00:01:58 +0000 |
---|---|---|
committer | adamk@google.com <adamk@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-02 00:01:58 +0000 |
commit | f1c244e1c3d0fc1b44cc3044c1c49b4fe799eb0c (patch) | |
tree | 8472a6b1cadfe2ed1cac8b786c63cf494785633d /content/browser/net | |
parent | cadea3888ab685b6e88589d008b9537e67a6d256 (diff) | |
download | chromium_src-f1c244e1c3d0fc1b44cc3044c1c49b4fe799eb0c.zip chromium_src-f1c244e1c3d0fc1b44cc3044c1c49b4fe799eb0c.tar.gz chromium_src-f1c244e1c3d0fc1b44cc3044c1c49b4fe799eb0c.tar.bz2 |
Revert 91390 (build breakage) - Convert ViewMsg_NetworkStateChanged from routed -> control
allowing it to be sent from BrowserRenderProcessHost::OnProcessLaunched
and minimizing the number of required IPCs (since the online state
is a per-WebKit singleton).
In doing so, I've disentangled online state management from TabContents: it now resides off by itself in BrowserOnlineStateObserver, a tiny class owned by BrowserProcessImpl.
BUG=7469,86538
TEST=begin with network disconnected, open new tab, load test page attached to 7469, then re-connect network
Review URL: http://codereview.chromium.org/7259004
TBR=eroman@chromium.org
Review URL: http://codereview.chromium.org/7300018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91392 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/net')
-rw-r--r-- | content/browser/net/browser_online_state_observer.cc | 24 | ||||
-rw-r--r-- | content/browser/net/browser_online_state_observer.h | 27 |
2 files changed, 0 insertions, 51 deletions
diff --git a/content/browser/net/browser_online_state_observer.cc b/content/browser/net/browser_online_state_observer.cc deleted file mode 100644 index 2b0ccd8..0000000 --- a/content/browser/net/browser_online_state_observer.cc +++ /dev/null @@ -1,24 +0,0 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#include "content/browser/net/browser_online_state_observer.h" - -#include "content/browser/renderer_host/render_process_host.h" -#include "content/common/view_messages.h" -#include "net/base/network_change_notifier.h" - -BrowserOnlineStateObserver::BrowserOnlineStateObserver() { - net::NetworkChangeNotifier::AddOnlineStateObserver(this); -} - -BrowserOnlineStateObserver::~BrowserOnlineStateObserver() { - net::NetworkChangeNotifier::RemoveOnlineStateObserver(this); -} - -void BrowserOnlineStateObserver::OnOnlineStateChanged(bool online) { - for (RenderProcessHost::iterator it(RenderProcessHost::AllHostsIterator()); - !it.IsAtEnd(); it.Advance()) { - it.GetCurrentValue()->Send(new ViewMsg_NetworkStateChanged(online)); - } -} diff --git a/content/browser/net/browser_online_state_observer.h b/content/browser/net/browser_online_state_observer.h deleted file mode 100644 index 1e5e71a..0000000 --- a/content/browser/net/browser_online_state_observer.h +++ /dev/null @@ -1,27 +0,0 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -#ifndef CONTENT_BROWSER_NET_BROWSER_ONLINE_STATE_OBSERVER_H_ -#define CONTENT_BROWSER_NET_BROWSER_ONLINE_STATE_OBSERVER_H_ -#pragma once - -#include "base/basictypes.h" -#include "net/base/network_change_notifier.h" - -// Listens for changes to the online state and manages sending -// updates to each RenderProcess via RenderProcessHost IPC. -class BrowserOnlineStateObserver - : public net::NetworkChangeNotifier::OnlineStateObserver { - public: - BrowserOnlineStateObserver(); - virtual ~BrowserOnlineStateObserver(); - - // OnlineStateObserver implementation. - virtual void OnOnlineStateChanged(bool online); - - private: - DISALLOW_COPY_AND_ASSIGN(BrowserOnlineStateObserver); -}; - -#endif // CONTENT_BROWSER_NET_BROWSER_ONLINE_STATE_OBSERVER_H_ |