diff options
| author | falken <falken@chromium.org> | 2015-04-15 09:49:39 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-04-15 16:50:08 +0000 |
| commit | 9573d4d33bf81518dd38c732bd18bfb8851bb89a (patch) | |
| tree | 8c57c651e265ad14eef64928fccf20342b3777fd /content/browser/push_messaging/push_messaging_router.cc | |
| parent | ece9b5e4d3e45d874d893f8422be0796c26bb702 (diff) | |
| download | chromium_src-9573d4d33bf81518dd38c732bd18bfb8851bb89a.zip chromium_src-9573d4d33bf81518dd38c732bd18bfb8851bb89a.tar.gz chromium_src-9573d4d33bf81518dd38c732bd18bfb8851bb89a.tar.bz2 | |
Service Worker: Use more specific errors when StartWorker fails
UMA shows StartWorker fails more than expected, but most errors are just
the generic START_WORKER_FAILED. Use a more specific error when appropriate.
This has some user-visible behavior change in the error message that register()
rejects with. For example, a syntax error used to fail with "ServiceWorker failed
to install"; now it fails with "ServiceWorker script evaluation failed".
A Blink layout test is added for error messages, which didn't have test
coverage previously.
BUG=448003
TEST=https://codereview.chromium.org/1058323004
Review URL: https://codereview.chromium.org/1063823005
Cr-Commit-Position: refs/heads/master@{#325261}
Diffstat (limited to 'content/browser/push_messaging/push_messaging_router.cc')
| -rw-r--r-- | content/browser/push_messaging/push_messaging_router.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/content/browser/push_messaging/push_messaging_router.cc b/content/browser/push_messaging/push_messaging_router.cc index 68d15af..0c78914 100644 --- a/content/browser/push_messaging/push_messaging_router.cc +++ b/content/browser/push_messaging/push_messaging_router.cc @@ -108,6 +108,7 @@ void PushMessagingRouter::DeliverMessageEnd( case SERVICE_WORKER_ERROR_NOT_FOUND: case SERVICE_WORKER_ERROR_IPC_FAILED: case SERVICE_WORKER_ERROR_TIMEOUT: + case SERVICE_WORKER_ERROR_SCRIPT_EVALUATE_FAILED: delivery_status = PUSH_DELIVERY_STATUS_SERVICE_WORKER_ERROR; break; case SERVICE_WORKER_ERROR_EXISTS: |