diff options
| author | falken <falken@chromium.org> | 2015-04-24 16:00:19 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-04-24 23:00:26 +0000 |
| commit | fb74da9cda4d943f453ad8e5de7b830174faf431 (patch) | |
| tree | 7424051d777497929086e885027410cb7c0ae16e /content/browser/push_messaging/push_messaging_router.cc | |
| parent | 2e7db0a2b9bd955352aee0762504b3c9c8c78fd0 (diff) | |
| download | chromium_src-fb74da9cda4d943f453ad8e5de7b830174faf431.zip chromium_src-fb74da9cda4d943f453ad8e5de7b830174faf431.tar.gz chromium_src-fb74da9cda4d943f453ad8e5de7b830174faf431.tar.bz2 | |
ServiceWorker: More accurate StartWorker result and UMA
This adds SERVICE_WORKER_ERROR_DISK_CACHE to indicate
failure to read from the disk cache. It also re-enables
logging of StartWorker for redundant workers. This was
previously disabled because we got a lot of "failed" spam
for updates that get aborted when there is no script change,
so I've changed StartWorker to fail with SW_ERROR_EXISTS in
that case.
This patch is a step in the direction of evicting a SW
that can't be read from disk cache.
BUG=448003
Review URL: https://codereview.chromium.org/1054033004
Cr-Commit-Position: refs/heads/master@{#326923}
Diffstat (limited to 'content/browser/push_messaging/push_messaging_router.cc')
| -rw-r--r-- | content/browser/push_messaging/push_messaging_router.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/content/browser/push_messaging/push_messaging_router.cc b/content/browser/push_messaging/push_messaging_router.cc index 76de068..905db11 100644 --- a/content/browser/push_messaging/push_messaging_router.cc +++ b/content/browser/push_messaging/push_messaging_router.cc @@ -109,6 +109,7 @@ void PushMessagingRouter::DeliverMessageEnd( case SERVICE_WORKER_ERROR_IPC_FAILED: case SERVICE_WORKER_ERROR_TIMEOUT: case SERVICE_WORKER_ERROR_SCRIPT_EVALUATE_FAILED: + case SERVICE_WORKER_ERROR_DISK_CACHE: delivery_status = PUSH_DELIVERY_STATUS_SERVICE_WORKER_ERROR; break; case SERVICE_WORKER_ERROR_EXISTS: |