diff options
| author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-19 18:53:54 +0000 |
|---|---|---|
| committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-19 18:53:54 +0000 |
| commit | 168dac6293496992304a0912ae206334e6eb938e (patch) | |
| tree | a34f72dc19a60dbabeaec4fbe8df596036fec561 /content/browser/renderer_host | |
| parent | 2abe9b2919b04cb8134fd51f2799800538c5764e (diff) | |
| download | chromium_src-168dac6293496992304a0912ae206334e6eb938e.zip chromium_src-168dac6293496992304a0912ae206334e6eb938e.tar.gz chromium_src-168dac6293496992304a0912ae206334e6eb938e.tar.bz2 | |
Fix the html select tag showing up at the wrong position. This was a regression from r166446.
The fix is to watch for the top level aura::Window's movement. In Ash, this would be an aura::Window that is the parent of the WebContents. In desktop Aura, this would be the aura::RootWindow. The change watches for this in WebContentsViewAura, similar to how WebContentsViewWin does this with PositionChangedMessageFilter. The reason is that the parent being watched needs to be updated with tab drags, so it's more convenient to do this at WebContentsViewAura's parent, instead of doing it at the RenderWidgetHostViewAura level (since that would need a list of parents).
This change also fixes OnHostMoved not being called on Windows.
BUG=161174
Review URL: https://codereview.chromium.org/11308083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168558 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/renderer_host')
| -rw-r--r-- | content/browser/renderer_host/render_widget_host_impl.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc index 51dd360..871c5c2 100644 --- a/content/browser/renderer_host/render_widget_host_impl.cc +++ b/content/browser/renderer_host/render_widget_host_impl.cc @@ -261,7 +261,7 @@ void RenderWidgetHostImpl::ResetSizeAndRepaintPendingFlags() { } void RenderWidgetHostImpl::SendScreenRects() { - if (waiting_for_screen_rects_ack_) + if (!renderer_initialized_ || waiting_for_screen_rects_ack_) return; if (is_hidden_) { |