diff options
| author | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-26 01:06:06 +0000 |
|---|---|---|
| committer | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-26 01:06:06 +0000 |
| commit | 512d03f78c442cf31bae077d93ecc4882a46b286 (patch) | |
| tree | 428c50889d8a1ded265b3dd90775cb300f12e2ae /content/browser/ssl/ssl_error_handler.h | |
| parent | 8c672de7d601eba2b337446bb869f08dece73633 (diff) | |
| download | chromium_src-512d03f78c442cf31bae077d93ecc4882a46b286.zip chromium_src-512d03f78c442cf31bae077d93ecc4882a46b286.tar.gz chromium_src-512d03f78c442cf31bae077d93ecc4882a46b286.tar.bz2 | |
RefCounted types should not have public destructors, delegate cleanup
For Delegate/Observer-type classes that specify an
interface but do not have any particular lifetime
requirements, make their destructors protected. This is to
allow their interfaces to be implemented safely by
RefCounted types. With public destructors, it's possible to
do "scoped_ptr<Delegate> foo", and then assign a
RefCountedDelegateImpl, which would lead to a double free.
As none of these Delegates actually need public destructors
(ownership of the Delegate* is not transferred during a
function call / class constructor), mark the destructors
protected so that it becomes a compile warning to try to
delete them via the Delegate*.
BUG=123295
TEST=it compiles
Review URL: https://chromiumcodereview.appspot.com/10383262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144086 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/ssl/ssl_error_handler.h')
| -rw-r--r-- | content/browser/ssl/ssl_error_handler.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/content/browser/ssl/ssl_error_handler.h b/content/browser/ssl/ssl_error_handler.h index 3063d16..a84f9fd 100644 --- a/content/browser/ssl/ssl_error_handler.h +++ b/content/browser/ssl/ssl_error_handler.h @@ -60,6 +60,9 @@ class SSLErrorHandler : public base::RefCountedThreadSafe<SSLErrorHandler> { // Called when SSLErrorHandler decides to continue the request despite the // SSL error. virtual void ContinueSSLRequest(const content::GlobalRequestID& id) = 0; + + protected: + virtual ~Delegate() {} }; virtual SSLCertErrorHandler* AsSSLCertErrorHandler(); |