Attach a SecurityStyle to each request in ResourceLoader

This CL adds a SecurityStyle to the serialized security information that
is sent with each request from the browser to the renderer. The
SecurityStyle describes the individual resource, not any bigger-picture
concerns like mixed content. The per-request SecurityStyle will be
displayed in DevTools to help developers diagnose SSL issues on
subresources.

BUG=502118, 445234

Review URL: https://codereview.chromium.org/1244863003

Cr-Commit-Position: refs/heads/master@{#340762}

1 files changed, 12 insertions, 5 deletions

diff --git a/content/browser/ssl/ssl_manager.cc b/content/browser/ssl/ssl_manager.cc
index ab1048c..e4c71e3 100644
--- a/content/browser/ssl/ssl_manager.cc
+++ b/content/browser/ssl/ssl_manager.cc
@@ -121,7 +121,10 @@ void SSLManager::DidCommitProvisionalLoad(const LoadCommittedDetails& details) {
     }
   }
 
-  UpdateEntry(entry);
+  policy()->UpdateEntry(entry, controller_->delegate()->GetWebContents());
+  // Always notify the WebContents that the SSL state changed when a
+  // load is committed, in case the active navigation entry has changed.
+  NotifyDidChangeVisibleSSLState();
 }
 
 void SSLManager::DidDisplayInsecureContent() {
@@ -184,12 +187,16 @@ void SSLManager::UpdateEntry(NavigationEntryImpl* entry) {
 
   SSLStatus original_ssl_status = entry->GetSSL();  // Copy!
 
-  WebContentsImpl* contents =
-      static_cast<WebContentsImpl*>(controller_->delegate()->GetWebContents());
-  policy()->UpdateEntry(entry, contents);
+  policy()->UpdateEntry(entry, controller_->delegate()->GetWebContents());
 
   if (!entry->GetSSL().Equals(original_ssl_status))
-    contents->DidChangeVisibleSSLState();
+    NotifyDidChangeVisibleSSLState();
+}
+
+void SSLManager::NotifyDidChangeVisibleSSLState() {
+  WebContentsImpl* contents =
+      static_cast<WebContentsImpl*>(controller_->delegate()->GetWebContents());
+  contents->DidChangeVisibleSSLState();
 }
 
 }  // namespace content