summaryrefslogtreecommitdiffstats
path: root/content/browser/ssl/ssl_manager.cc
diff options
context:
space:
mode:
authoravi <avi@chromium.org>2015-07-08 12:33:59 -0700
committerCommit bot <commit-bot@chromium.org>2015-07-08 19:35:51 +0000
commite0d90188576ca7206a7a411e1bfe45c898440d7d (patch)
treeee3b8af63fbeff86f7987294ca103c95c2e78e07 /content/browser/ssl/ssl_manager.cc
parentfb5dce12f0462056fc9f66967b0f7b2b7bcd88f5 (diff)
downloadchromium_src-e0d90188576ca7206a7a411e1bfe45c898440d7d.zip
chromium_src-e0d90188576ca7206a7a411e1bfe45c898440d7d.tar.gz
chromium_src-e0d90188576ca7206a7a411e1bfe45c898440d7d.tar.bz2
Clean up the interface to DeserializeSecurityInfo, fix uninitialized memory use.
BUG=507018 TEST=clusterfuzz is happy Review URL: https://codereview.chromium.org/1225983003 Cr-Commit-Position: refs/heads/master@{#337883}
Diffstat (limited to 'content/browser/ssl/ssl_manager.cc')
-rw-r--r--content/browser/ssl/ssl_manager.cc25
1 files changed, 3 insertions, 22 deletions
diff --git a/content/browser/ssl/ssl_manager.cc b/content/browser/ssl/ssl_manager.cc
index 865ca60..6f258a7 100644
--- a/content/browser/ssl/ssl_manager.cc
+++ b/content/browser/ssl/ssl_manager.cc
@@ -115,29 +115,10 @@ void SSLManager::DidCommitProvisionalLoad(const LoadCommittedDetails& details) {
if (details.is_main_frame) {
if (entry) {
- // Decode the security details.
- int ssl_cert_id;
- net::CertStatus ssl_cert_status;
- int ssl_security_bits;
- int ssl_connection_status;
- SignedCertificateTimestampIDStatusList
- ssl_signed_certificate_timestamp_ids;
- DeserializeSecurityInfo(details.serialized_security_info,
- &ssl_cert_id,
- &ssl_cert_status,
- &ssl_security_bits,
- &ssl_connection_status,
- &ssl_signed_certificate_timestamp_ids);
-
// We may not have an entry if this is a navigation to an initial blank
- // page. Reset the SSL information and add the new data we have.
- entry->GetSSL() = SSLStatus();
- entry->GetSSL().cert_id = ssl_cert_id;
- entry->GetSSL().cert_status = ssl_cert_status;
- entry->GetSSL().security_bits = ssl_security_bits;
- entry->GetSSL().connection_status = ssl_connection_status;
- entry->GetSSL().signed_certificate_timestamp_ids =
- ssl_signed_certificate_timestamp_ids;
+ // page. Add the new data we have.
+ entry->GetSSL() =
+ DeserializeSecurityInfo(details.serialized_security_info);
}
}