summaryrefslogtreecommitdiffstats
path: root/content/browser/ssl
diff options
context:
space:
mode:
authornasko@chromium.org <nasko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-10-09 04:03:27 +0000
committernasko@chromium.org <nasko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-10-09 04:03:27 +0000
commit6286a3798e51456de431d03d184a2f13ee5f2545 (patch)
tree07019e564914ef5a5615892710d8a8a9761cdaa4 /content/browser/ssl
parentbe84f3b6c028140ece0efad6d77c8f8c2c88b180 (diff)
downloadchromium_src-6286a3798e51456de431d03d184a2f13ee5f2545.zip
chromium_src-6286a3798e51456de431d03d184a2f13ee5f2545.tar.gz
chromium_src-6286a3798e51456de431d03d184a2f13ee5f2545.tar.bz2
Remove GetActiveEntry usage from content.
This is a copy of https://chromiumcodereview.appspot.com/23022006, which was reverted due to perf regression. The root cause was WebContentsImpl::GetWebkitPrefs using GetLastCommittedEntry, which caused compositing to be disabled and higher memory usage on Mac. I've removed that part of the change and will investigate separately how to best fix it. BUG=273710 Review URL: https://codereview.chromium.org/25654005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227665 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/ssl')
-rw-r--r--content/browser/ssl/ssl_manager.cc11
1 files changed, 7 insertions, 4 deletions
diff --git a/content/browser/ssl/ssl_manager.cc b/content/browser/ssl/ssl_manager.cc
index 42ee02f..6a6572a 100644
--- a/content/browser/ssl/ssl_manager.cc
+++ b/content/browser/ssl/ssl_manager.cc
@@ -87,7 +87,7 @@ void SSLManager::NotifySSLInternalStateChanged(BrowserContext* context) {
for (std::set<SSLManager*>::iterator i = managers->get().begin();
i != managers->get().end(); ++i) {
(*i)->UpdateEntry(NavigationEntryImpl::FromNavigationEntry(
- (*i)->controller()->GetActiveEntry()));
+ (*i)->controller()->GetLastCommittedEntry()));
}
}
@@ -114,7 +114,8 @@ SSLManager::~SSLManager() {
void SSLManager::DidCommitProvisionalLoad(const LoadCommittedDetails& details) {
NavigationEntryImpl* entry =
- NavigationEntryImpl::FromNavigationEntry(controller_->GetActiveEntry());
+ NavigationEntryImpl::FromNavigationEntry(
+ controller_->GetLastCommittedEntry());
if (details.is_main_frame) {
if (entry) {
@@ -144,12 +145,14 @@ void SSLManager::DidCommitProvisionalLoad(const LoadCommittedDetails& details) {
void SSLManager::DidDisplayInsecureContent() {
UpdateEntry(
- NavigationEntryImpl::FromNavigationEntry(controller_->GetActiveEntry()));
+ NavigationEntryImpl::FromNavigationEntry(
+ controller_->GetLastCommittedEntry()));
}
void SSLManager::DidRunInsecureContent(const std::string& security_origin) {
NavigationEntryImpl* navigation_entry =
- NavigationEntryImpl::FromNavigationEntry(controller_->GetActiveEntry());
+ NavigationEntryImpl::FromNavigationEntry(
+ controller_->GetLastCommittedEntry());
policy()->DidRunInsecureContent(navigation_entry, security_origin);
UpdateEntry(navigation_entry);
}