diff options
| author | ajwong@chromium.org <ajwong@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-27 05:56:17 +0000 |
|---|---|---|
| committer | ajwong@chromium.org <ajwong@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-27 05:56:17 +0000 |
| commit | 44080e71f9994cfa0c52c470196e7993a4cb9482 (patch) | |
| tree | 776f2765d6c45b2a57158e0490b070ce3afb5f55 /content/browser/storage_partition_impl_unittest.cc | |
| parent | 50f92668f15f6da453389e6e8705e3aef9ae1a07 (diff) | |
| download | chromium_src-44080e71f9994cfa0c52c470196e7993a4cb9482.zip chromium_src-44080e71f9994cfa0c52c470196e7993a4cb9482.tar.gz chromium_src-44080e71f9994cfa0c52c470196e7993a4cb9482.tar.bz2 | |
Remove the Extensions URLRequestContext.
Though chrome-extension: scheme URLs support cookies, they do not share
a namespace with http: and https:. In particular, chrome-extension://a and
http://a should not have the same set of cookies.
To enforce this, previously the code created a completely separate
URLRequestContext for servicing chrome-extension: schemes. However,
the code really only used this object as a method for conveying the
correct cookie jar from Profile creation to a few spots where cookies
were accessed; the rest of the URLRequestContext functionality was unused.
This CL removes the Extensions URLRequestContext code and replaces it
with APIs that directly expose the needed net::CookieStore.
Lastly, CookieMonster::EnableFileScheme() is removed and
CookieMonster::Delegate is renamed CookieMonsterDelegate.
EnableFileScheme is an inherently racy API because
CookieMonsters are creatable on all threads and this
function sets an unprotected global flag. CookieMonsterDelegate
is preferable to the nested interface because it can now be
forward declared.
TBRing darin and sky to cover the rest of the mechanical unittest changes.
TBR=darin,sky
BUG=158386,159193,57884
Review URL: https://chromiumcodereview.appspot.com/12546016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219709 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/storage_partition_impl_unittest.cc')
| -rw-r--r-- | content/browser/storage_partition_impl_unittest.cc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/content/browser/storage_partition_impl_unittest.cc b/content/browser/storage_partition_impl_unittest.cc index a8b47bc..c14a7d4 100644 --- a/content/browser/storage_partition_impl_unittest.cc +++ b/content/browser/storage_partition_impl_unittest.cc @@ -8,6 +8,7 @@ #include "base/threading/thread.h" #include "content/browser/browser_thread_impl.h" #include "content/browser/gpu/shader_disk_cache.h" +#include "content/browser/net/cookie_store_map.h" #include "content/browser/storage_partition_impl.h" #include "content/public/browser/storage_partition.h" #include "content/public/test/test_browser_thread_bundle.h" @@ -109,8 +110,8 @@ TEST_F(StoragePartitionShaderClearTest, ClearShaderCache) { EXPECT_EQ(1u, Size()); TestClosureCallback clear_cb; - StoragePartitionImpl sp( - cache_path(), NULL, NULL, NULL, NULL, NULL, NULL, NULL); + StoragePartitionImpl sp(cache_path(), NULL, NULL, NULL, NULL, NULL, NULL, + scoped_ptr<CookieStoreMap>(), NULL); base::MessageLoop::current()->PostTask( FROM_HERE, base::Bind(&ClearData, &sp, clear_cb.callback())); clear_cb.WaitForResult(); |