diff options
author | thestig <thestig@chromium.org> | 2014-10-23 17:21:15 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-10-24 00:21:27 +0000 |
commit | 62675d9fb31fb8cedc40f68e78e8445a74f362e7 (patch) | |
tree | 7ba05b92cf1a1075f9dfc1c11171e96ce683cf3d /content/browser/udev_linux.cc | |
parent | 55196a2b4a303ddbc46f2b63b58c725f80710c9c (diff) | |
download | chromium_src-62675d9fb31fb8cedc40f68e78e8445a74f362e7.zip chromium_src-62675d9fb31fb8cedc40f68e78e8445a74f362e7.tar.gz chromium_src-62675d9fb31fb8cedc40f68e78e8445a74f362e7.tar.bz2 |
Cleanup: Merge device/udev_linux/udev.{cc,h} into device/udev_linux/scoped_udev.h.
- Update header files elsewhere.
- Use ScopedUdev*Ptr classes in more places.
BUG=415212
Review URL: https://codereview.chromium.org/666653002
Cr-Commit-Position: refs/heads/master@{#300999}
Diffstat (limited to 'content/browser/udev_linux.cc')
-rw-r--r-- | content/browser/udev_linux.cc | 20 |
1 files changed, 8 insertions, 12 deletions
diff --git a/content/browser/udev_linux.cc b/content/browser/udev_linux.cc index f6f9443..80c929b 100644 --- a/content/browser/udev_linux.cc +++ b/content/browser/udev_linux.cc @@ -13,23 +13,21 @@ namespace content { UdevLinux::UdevLinux(const std::vector<UdevMonitorFilter>& filters, const UdevNotificationCallback& callback) : udev_(udev_new()), - monitor_(NULL), + monitor_(udev_monitor_new_from_netlink(udev_.get(), "udev")), monitor_fd_(-1), callback_(callback) { CHECK(udev_); - - monitor_ = udev_monitor_new_from_netlink(udev_, "udev"); CHECK(monitor_); for (size_t i = 0; i < filters.size(); ++i) { int ret = udev_monitor_filter_add_match_subsystem_devtype( - monitor_, filters[i].subsystem, filters[i].devtype); + monitor_.get(), filters[i].subsystem, filters[i].devtype); CHECK_EQ(0, ret); } - int ret = udev_monitor_enable_receiving(monitor_); + int ret = udev_monitor_enable_receiving(monitor_.get()); CHECK_EQ(0, ret); - monitor_fd_ = udev_monitor_get_fd(monitor_); + monitor_fd_ = udev_monitor_get_fd(monitor_.get()); CHECK_GE(monitor_fd_, 0); bool success = base::MessageLoopForIO::current()->WatchFileDescriptor( @@ -43,12 +41,10 @@ UdevLinux::UdevLinux(const std::vector<UdevMonitorFilter>& filters, UdevLinux::~UdevLinux() { monitor_watcher_.StopWatchingFileDescriptor(); - udev_monitor_unref(monitor_); - udev_unref(udev_); } udev* UdevLinux::udev_handle() { - return udev_; + return udev_.get(); } void UdevLinux::OnFileCanReadWithoutBlocking(int fd) { @@ -56,12 +52,12 @@ void UdevLinux::OnFileCanReadWithoutBlocking(int fd) { // change state. udev_monitor_receive_device() will return a device object // representing the device which changed and what type of change occured. DCHECK_EQ(monitor_fd_, fd); - udev_device* dev = udev_monitor_receive_device(monitor_); + device::ScopedUdevDevicePtr dev( + udev_monitor_receive_device(monitor_.get())); if (!dev) return; - callback_.Run(dev); - udev_device_unref(dev); + callback_.Run(dev.get()); } void UdevLinux::OnFileCanWriteWithoutBlocking(int fd) { |