summaryrefslogtreecommitdiffstats
path: root/content/browser/webui
diff options
context:
space:
mode:
authorjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-05 23:28:35 +0000
committerjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-05 23:28:35 +0000
commiteabbfb19a4edd46aa81b03f9c695a6f70789b8bd (patch)
tree124b2219f4f597e0a8e5f66bb915868d3c3a84ef /content/browser/webui
parent92c8a60f72634bd5ceb8cf72aa7ddf2ea689fbeb (diff)
downloadchromium_src-eabbfb19a4edd46aa81b03f9c695a6f70789b8bd.zip
chromium_src-eabbfb19a4edd46aa81b03f9c695a6f70789b8bd.tar.gz
chromium_src-eabbfb19a4edd46aa81b03f9c695a6f70789b8bd.tar.bz2
Hide ContentClient getters from embedders so that they they don't reuse content's embedder API. The main reasons are that it makes content's embedder interfaces harder to change if they're reused by the embedder, and that its makes it confusing for embedder code when there are multiple ways to do the same thing.
BUG=227047 Review URL: https://codereview.chromium.org/13409003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192649 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser/webui')
-rw-r--r--content/browser/webui/web_ui_data_source_unittest.cc8
1 files changed, 1 insertions, 7 deletions
diff --git a/content/browser/webui/web_ui_data_source_unittest.cc b/content/browser/webui/web_ui_data_source_unittest.cc
index b58161c..24d1d2b 100644
--- a/content/browser/webui/web_ui_data_source_unittest.cc
+++ b/content/browser/webui/web_ui_data_source_unittest.cc
@@ -52,7 +52,7 @@ class TestClient : public TestContentClient {
class WebUIDataSourceTest : public testing::Test {
public:
- WebUIDataSourceTest() : result_data_(NULL), old_client_(NULL) {}
+ WebUIDataSourceTest() : result_data_(NULL) {}
virtual ~WebUIDataSourceTest() {}
WebUIDataSourceImpl* source() { return source_.get(); }
@@ -72,7 +72,6 @@ class WebUIDataSourceTest : public testing::Test {
private:
virtual void SetUp() {
- old_client_ = GetContentClient();
SetContentClient(&client_);
WebUIDataSource* source = WebUIDataSourceImpl::Create("host");
WebUIDataSourceImpl* source_impl = static_cast<WebUIDataSourceImpl*>(
@@ -81,10 +80,6 @@ class WebUIDataSourceTest : public testing::Test {
source_ = make_scoped_refptr(source_impl);
}
- virtual void TearDown() {
- SetContentClient(old_client_);
- }
-
// Store response for later comparisons.
void SendResult(base::RefCountedMemory* data) {
result_data_ = data;
@@ -92,7 +87,6 @@ class WebUIDataSourceTest : public testing::Test {
scoped_refptr<WebUIDataSourceImpl> source_;
TestClient client_;
- ContentClient* old_client_;
};
TEST_F(WebUIDataSourceTest, EmptyStrings) {