diff options
| author | asanka@chromium.org <asanka@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-06 20:55:00 +0000 |
|---|---|---|
| committer | asanka@chromium.org <asanka@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-06 20:55:00 +0000 |
| commit | 0afff03fd4a562078a93863bd44f003bafe0ab8e (patch) | |
| tree | bb0e7575ab40bf751f045fcf5ae9bf425ae5c140 /content/browser | |
| parent | ce254be34030d99821048af334564adf23002529 (diff) | |
| download | chromium_src-0afff03fd4a562078a93863bd44f003bafe0ab8e.zip chromium_src-0afff03fd4a562078a93863bd44f003bafe0ab8e.tar.gz chromium_src-0afff03fd4a562078a93863bd44f003bafe0ab8e.tar.bz2 | |
Cleanup parameter passing issues in content/browser/download
CID=102857, 102858
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9108024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116734 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/browser')
4 files changed, 12 insertions, 12 deletions
diff --git a/content/browser/download/download_manager_impl.cc b/content/browser/download/download_manager_impl.cc index e422120..09371a3 100644 --- a/content/browser/download/download_manager_impl.cc +++ b/content/browser/download/download_manager_impl.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -425,7 +425,7 @@ void DownloadManagerImpl::ContinueDownloadWithPath( void DownloadManagerImpl::UpdateDownload(int32 download_id, int64 bytes_so_far, int64 bytes_per_sec, - std::string hash_state) { + const std::string& hash_state) { DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); DownloadMap::iterator it = active_downloads_.find(download_id); if (it != active_downloads_.end()) { @@ -624,7 +624,7 @@ void DownloadManagerImpl::DownloadCancelled(DownloadItem* download) { void DownloadManagerImpl::OnDownloadInterrupted(int32 download_id, int64 size, - std::string hash_state, + const std::string& hash_state, InterruptReason reason) { DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); diff --git a/content/browser/download/download_manager_impl.h b/content/browser/download/download_manager_impl.h index 9e4e44f..f638fe8 100644 --- a/content/browser/download/download_manager_impl.h +++ b/content/browser/download/download_manager_impl.h @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. // @@ -48,13 +48,13 @@ class CONTENT_EXPORT DownloadManagerImpl virtual void UpdateDownload(int32 download_id, int64 bytes_so_far, int64 bytes_per_sec, - std::string hash_state) OVERRIDE; + const std::string& hash_state) OVERRIDE; virtual void OnResponseCompleted(int32 download_id, int64 size, const std::string& hash) OVERRIDE; virtual void CancelDownload(int32 download_id) OVERRIDE; virtual void OnDownloadInterrupted(int32 download_id, int64 size, - std::string hash_state, + const std::string& hash_state, InterruptReason reason) OVERRIDE; virtual void OnDownloadRenamedToFinalName(int download_id, const FilePath& full_path, diff --git a/content/browser/download/mock_download_manager.cc b/content/browser/download/mock_download_manager.cc index e1cb48c..74f3e84 100644 --- a/content/browser/download/mock_download_manager.cc +++ b/content/browser/download/mock_download_manager.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -56,7 +56,7 @@ void MockDownloadManager::StartDownload(int32 id) { void MockDownloadManager::UpdateDownload(int32 download_id, int64 bytes_so_far, int64 bytes_per_sec, - std::string hash_state) { + const std::string& hash_state) { } void MockDownloadManager::OnResponseCompleted(int32 download_id, int64 size, @@ -68,7 +68,7 @@ void MockDownloadManager::CancelDownload(int32 download_id) { void MockDownloadManager::OnDownloadInterrupted(int32 download_id, int64 size, - std::string hash_state, + const std::string& hash_state, InterruptReason reason) { } diff --git a/content/browser/download/mock_download_manager.h b/content/browser/download/mock_download_manager.h index fa27df9..3172d6e 100644 --- a/content/browser/download/mock_download_manager.h +++ b/content/browser/download/mock_download_manager.h @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -33,13 +33,13 @@ class MockDownloadManager : public content::DownloadManager { virtual void UpdateDownload(int32 download_id, int64 bytes_so_far, int64 bytes_per_sec, - std::string hash_state) OVERRIDE; + const std::string& hash_state) OVERRIDE; virtual void OnResponseCompleted(int32 download_id, int64 size, const std::string& hash) OVERRIDE; virtual void CancelDownload(int32 download_id) OVERRIDE; virtual void OnDownloadInterrupted(int32 download_id, int64 size, - std::string hash_state, + const std::string& hash_state, InterruptReason reason) OVERRIDE; virtual void OnDownloadRenamedToFinalName(int download_id, const FilePath& full_path, |