diff options
| author | fischman@chromium.org <fischman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-02 23:50:57 +0000 |
|---|---|---|
| committer | fischman@chromium.org <fischman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-02 23:50:57 +0000 |
| commit | c7a94521acf01bdf519bb57801fdbc3c2a50616d (patch) | |
| tree | ed86ab44ba8c9b7340557c3aba552385209efdfa /content/common/browser_plugin | |
| parent | f4025f54e37ab902f71ba0e3690a11e5719b5d39 (diff) | |
| download | chromium_src-c7a94521acf01bdf519bb57801fdbc3c2a50616d.zip chromium_src-c7a94521acf01bdf519bb57801fdbc3c2a50616d.tar.gz chromium_src-c7a94521acf01bdf519bb57801fdbc3c2a50616d.tar.bz2 | |
Revert 209776 "Revert 209761 "Fix BrowserPluginHostTest.PartialA..."
speculative revert was speculative; test passed once before revert landed, and failed once after revert landed, so these are not the droids we're looking for.
> Revert 209761 "Fix BrowserPluginHostTest.PartialAutosizeAttribut..."
> Speculative revert to deal with new WebViewInteractiveTest.PopupPositioning crash (e.g. http://build.chromium.org/p/chromium.memory/buildstatus?builder=Mac%20ASAN%20Tests%20%283%29&number=9207 and http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.6%20Tests%20%281%29&number=42192)
>
> > Fix BrowserPluginHostTest.PartialAutosizeAttributes flake
> >
> > The compositing path was exiting BrowserPlugin::OnUpdateRect early
> > and so updated autosize parameters weren't making it to BrowserPluginGuest.
> >
> > BUG=255591
> > Test=BrowserPluginHostTest.PartialAutosizeAttributes no longer flakes locally
> >
> > Review URL: https://chromiumcodereview.appspot.com/18223004
>
> TBR=fsamuel@chromium.org
>
> Review URL: https://codereview.chromium.org/18566005
TBR=fischman@chromium.org
Review URL: https://codereview.chromium.org/18054026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209821 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/common/browser_plugin')
| -rw-r--r-- | content/common/browser_plugin/browser_plugin_messages.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/content/common/browser_plugin/browser_plugin_messages.h b/content/common/browser_plugin/browser_plugin_messages.h index cb6cc0d..ce965e7 100644 --- a/content/common/browser_plugin/browser_plugin_messages.h +++ b/content/common/browser_plugin/browser_plugin_messages.h @@ -204,8 +204,9 @@ IPC_MESSAGE_ROUTED3(BrowserPluginHostMsg_HandleInputEvent, // the previous frame and is ready for the next frame. If the guest sent the // embedder a bitmap that does not match the size of the BrowserPlugin's // container, the BrowserPlugin requests a new size as well. -IPC_MESSAGE_ROUTED3(BrowserPluginHostMsg_UpdateRect_ACK, +IPC_MESSAGE_ROUTED4(BrowserPluginHostMsg_UpdateRect_ACK, int /* instance_id */, + bool /* needs_ack */, BrowserPluginHostMsg_AutoSize_Params /* auto_size_params */, BrowserPluginHostMsg_ResizeGuest_Params /* resize_guest_params */) |