diff options
| author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-30 17:00:32 +0000 |
|---|---|---|
| committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-30 17:00:32 +0000 |
| commit | a794f3a483eb549dbe3484592bba31c07f2eab4a (patch) | |
| tree | 3d1f6a3435a444adbfabadc558955482f09de975 /content/common/java_bridge_messages.h | |
| parent | 1b563dfcd6f14abd5f85d7158f4d7f6da9ea1180 (diff) | |
| download | chromium_src-a794f3a483eb549dbe3484592bba31c07f2eab4a.zip chromium_src-a794f3a483eb549dbe3484592bba31c07f2eab4a.tar.gz chromium_src-a794f3a483eb549dbe3484592bba31c07f2eab4a.tar.bz2 | |
Make JavaBridgeDispatcherHost not be a RenderViewHostObserver anymore.
The only reason it was inheriting from it was to to dispatch an IPC from the renderer. Dispatch the IPC in WebContentsImpl instead, since that already knows about the java bridge code and send it to JavaBridgeDispatcherHostManager. I did this instead of exposing WebContentsImpl::message_source_ as no one else needs this yet, and I'm nervous of exposing it in case of misuse.
This also fixes usage of RenderProcessHost and RenderViewHost on the background java thread, which is not thread-safe, and a possible use-after-free with RenderViewHost.
This is part of the work in removing RenderViewHostObserver.
BUG=306569
R=steveblock@chromium.org, torne@chromium.org
Review URL: https://codereview.chromium.org/45933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231856 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/common/java_bridge_messages.h')
| -rw-r--r-- | content/common/java_bridge_messages.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/content/common/java_bridge_messages.h b/content/common/java_bridge_messages.h index 62923c7..7f2d8c1 100644 --- a/content/common/java_bridge_messages.h +++ b/content/common/java_bridge_messages.h @@ -16,9 +16,6 @@ // Messages for handling Java objects injected into JavaScript ----------------- -// Sent from browser to renderer to initialize the Java Bridge. -IPC_MESSAGE_ROUTED0(JavaBridgeMsg_Init) - // Sent from browser to renderer to add a Java object with the given name. IPC_MESSAGE_ROUTED2(JavaBridgeMsg_AddNamedObject, string16 /* name */, |