diff options
| author | gab@chromium.org <gab@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-01 08:15:08 +0000 |
|---|---|---|
| committer | gab@chromium.org <gab@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-01 08:15:08 +0000 |
| commit | 7b05ccee4c8ba817df06747559fcb200df350b0c (patch) | |
| tree | b32f19222e5a5e48190cb8eed85dafb2bdc694be /content/common/sandbox_win.cc | |
| parent | ab4ec5079e42927bb608543a38f6376e02dadcd5 (diff) | |
| download | chromium_src-7b05ccee4c8ba817df06747559fcb200df350b0c.zip chromium_src-7b05ccee4c8ba817df06747559fcb200df350b0c.tar.gz chromium_src-7b05ccee4c8ba817df06747559fcb200df350b0c.tar.bz2 | |
Use DPLOGs if error code is SBOX_ERROR_GENERIC to GetLastError as SBOX_ERROR_GENERIC's definition suggests.
BUG=Otherwise this DLOG would output error 1; which isn't useful to know what the win32 error actually was.
Review URL: https://chromiumcodereview.appspot.com/21015012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214988 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/common/sandbox_win.cc')
| -rw-r--r-- | content/common/sandbox_win.cc | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/content/common/sandbox_win.cc b/content/common/sandbox_win.cc index 83f3f72..1645548 100644 --- a/content/common/sandbox_win.cc +++ b/content/common/sandbox_win.cc @@ -679,14 +679,16 @@ base::ProcessHandle StartSandboxedProcess( TRACE_EVENT_END_ETW("StartProcessWithAccess::LAUNCHPROCESS", 0, 0); if (sandbox::SBOX_ALL_OK != result) { - DLOG(ERROR) << "Failed to launch process. Error: " << result; + if (result == sandbox::SBOX_ERROR_GENERIC) + DPLOG(ERROR) << "Failed to launch process"; + else + DLOG(ERROR) << "Failed to launch process. Error: " << result; return 0; } if (delegate) delegate->PostSpawnTarget(target.process_handle()); - ResumeThread(target.thread_handle()); // Help the process a little. It can't start the debugger by itself if |