diff options
author | fischman@chromium.org <fischman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-05 23:07:23 +0000 |
---|---|---|
committer | fischman@chromium.org <fischman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-07-05 23:07:23 +0000 |
commit | 6dfa4da3cd6954e09e7459fb15eed112188dc7db (patch) | |
tree | ff32d31980b693ea41e10b65a252585755fe873e /content/content_common.gypi | |
parent | cc93117a0a76174f8f61e23e6f33874ceb088f0c (diff) | |
download | chromium_src-6dfa4da3cd6954e09e7459fb15eed112188dc7db.zip chromium_src-6dfa4da3cd6954e09e7459fb15eed112188dc7db.tar.gz chromium_src-6dfa4da3cd6954e09e7459fb15eed112188dc7db.tar.bz2 |
Make VideoDecodeAcceleratorTest work for VAVDA and fixed a bunch of bugs the test found
Reland 145556 & 145557 (a compile fix for the Mac & ARM builders)
- The bulk of the CL turns RenderingHelperEGL into RenderingHelperGL (by making
it EGL-vs-GLX-agnostic)
- VaapiH264Decoder::AssignPictureBuffer: it's fine to restart decode after a
Reset(), so allow that.
- VaapiH264Decoder::FillVARefFramesFromDPB: faster/clearer error condition, and
small cleanup.
- VaapiH264Decoder::Flush: emit the final in-progress picture.
- VaapiH264Decoder::DecodeOneFrame: insist on having at least two output
surfaces before attempting a decode to avoid running out.
- VaapiVideoDecodeAccelerator::client_ is now a WeakPtr instead of a raw
pointer, to do correct lifetime accounting. This also allows dropping the
helper methods on VAVDA whose only purpose was to triple-check client_'s
presence before dispatching calls on it.
- VaapiVideoDecodeAccelerator::InitialDecodeTask: account for the possibility of
multiple in-flight Decode()s, and remove unnecessary task-posting.
Two remaining issues are:
- the test-25fps.h264 testdata file triggers bug#135548
- the pure-decode performance (at least in Debug) of VAVDA is not as good as the reference that vdatest was originally built for, so some tests "fail" on lower-than-expected fps rates. This probably just needs to be a per-platform expectation.
TBR=brettw@chromium.org, posciak@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10693107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145561 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/content_common.gypi')
-rw-r--r-- | content/content_common.gypi | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/content/content_common.gypi b/content/content_common.gypi index d7412c7..cb1860f 100644 --- a/content/content_common.gypi +++ b/content/content_common.gypi @@ -424,7 +424,7 @@ ], }, }], - ['chromeos == 1', { + ['target_arch != "arm" and (OS=="linux" or chromeos == 1)', { 'sources': [ 'common/gpu/media/h264_dpb.cc', 'common/gpu/media/h264_dpb.h', |