diff options
| author | miguelg@chromium.org <miguelg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-08 11:10:37 +0000 |
|---|---|---|
| committer | miguelg@chromium.org <miguelg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-08 11:11:37 +0000 |
| commit | f250fa5dd72b9f7368f7853a02382f0d6f971bc7 (patch) | |
| tree | 5ec07b1f071fc8304cc1a998b0f3ffda81e68fbb /content/content_tests.gypi | |
| parent | b6445d911d39329886f851c933297b6089c40c16 (diff) | |
| download | chromium_src-f250fa5dd72b9f7368f7853a02382f0d6f971bc7.zip chromium_src-f250fa5dd72b9f7368f7853a02382f0d6f971bc7.tar.gz chromium_src-f250fa5dd72b9f7368f7853a02382f0d6f971bc7.tar.bz2 | |
Revert of [Android] Use UIResource for overscroll glow (https://codereview.chromium.org/422013003/)
Reason for revert:
This is breaking chrome ToT downstream and the change quie complex so
I don't feel qualified to try to fix it in place.
The failure we hit is
F/chromium( 2961): [FATAL:system_ui_resource_manager_impl.cc(35)] Check failed: !bitmap.empty().
See an example of a failed run in
https://uberchromegw.corp.google.com/i/clank.tot/builders/instrumentation-yakju-clankium-tot/builds/32007
(but just trying to boot clank with this patch will trigger it)
Original issue's description:
> [Android] Use UIResource for overscroll glow
>
> Introduce a SystemUIResourceManager class for loading and providing access to
> shared UIResourceId's. Wire this class to the existing OverscrollGlow effect,
> using the shared id's with a UIResourceLayer for both glow and edge layers.
>
> This patch is a subset of powei@'s original SystemUIResource patch found at
> https://codereview.chromium.org/377013002/.
>
> BUG=326326
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288095
TBR=aelias@chromium.org,powei@chromium.org,yfriedman@chromium.org,sky@chromium.org,jdduke@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=326326
Review URL: https://codereview.chromium.org/454863003
Cr-Commit-Position: refs/heads/master@{#288330}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288330 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/content_tests.gypi')
| -rw-r--r-- | content/content_tests.gypi | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/content/content_tests.gypi b/content/content_tests.gypi index bf2ea21..1743750 100644 --- a/content/content_tests.gypi +++ b/content/content_tests.gypi @@ -901,7 +901,6 @@ 'browser/android/java/gin_java_method_invocation_helper_unittest.cc', 'browser/android/java/java_type_unittest.cc', 'browser/android/java/jni_helper_unittest.cc', - 'browser/android/system_ui_resource_manager_impl_unittest.cc', 'renderer/java/gin_java_bridge_value_converter_unittest.cc', ], 'sources!': [ |