diff options
| author | xhwang@chromium.org <xhwang@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-12 00:47:25 +0000 |
|---|---|---|
| committer | xhwang@chromium.org <xhwang@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-12 00:47:25 +0000 |
| commit | 54807292a388fe912e848e4589c112c30dd9c51c (patch) | |
| tree | 3e2cc3f8b5ef755c5ae521322ecedd46f9a3092c /content/content_tests.gypi | |
| parent | 5c5a88eb6550c82143afec70d114a68f2bd8635b (diff) | |
| download | chromium_src-54807292a388fe912e848e4589c112c30dd9c51c.zip chromium_src-54807292a388fe912e848e4589c112c30dd9c51c.tar.gz chromium_src-54807292a388fe912e848e4589c112c30dd9c51c.tar.bz2 | |
Add check on invalid file descriptor at both broker and renderer sides.
The broker could send back an invalide channel handle if it fails to setup up renderer channel, e.g. when the broker fails to duplicate a file descriptor. Add a check in PpapiThread::SetupRendererChannel on this condition. Upon receiving an invalid channel handle from the broker, the BrokerDispatcherWrapper at the render side should check the channel handle before passing it down. Using an invalid channel handle to create a channel may cause LOG(FATAL) in IPC::Channel::ChannelImpl::CreatePipe().
Add a content unitest to check this.
BUG=103957
TEST=new unit test
Review URL: http://codereview.chromium.org/8436008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109747 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/content_tests.gypi')
| -rw-r--r-- | content/content_tests.gypi | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/content/content_tests.gypi b/content/content_tests.gypi index 0e249c5..a7a2df1 100644 --- a/content/content_tests.gypi +++ b/content/content_tests.gypi @@ -229,6 +229,7 @@ 'renderer/media/video_capture_message_filter_unittest.cc', 'renderer/media/webrtc_audio_device_unittest.cc', 'renderer/paint_aggregator_unittest.cc', + 'renderer/pepper_plugin_delegate_impl_unittest.cc', 'renderer/v8_value_converter_impl_unittest.cc', 'test/run_all_unittests.cc', ], |