diff options
| author | jamesr@chromium.org <jamesr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-01 03:45:51 +0000 |
|---|---|---|
| committer | jamesr@chromium.org <jamesr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-06-01 03:45:51 +0000 |
| commit | 4c0e289d9064b680215dfd31737937ec2edd0f5c (patch) | |
| tree | 86c21698a71d460ac51f4af863a22f0e12afb18f /content/gpu/gpu_child_thread.cc | |
| parent | 593abb8eebd6d980bdea0e5ab3d933da34cbaaf4 (diff) | |
| download | chromium_src-4c0e289d9064b680215dfd31737937ec2edd0f5c.zip chromium_src-4c0e289d9064b680215dfd31737937ec2edd0f5c.tar.gz chromium_src-4c0e289d9064b680215dfd31737937ec2edd0f5c.tar.bz2 | |
Set the unblock flag to false for all gpu->renderer IPCs
The GPU process should never send sync IPCs to other processes so we don't need
to set the unblock flag for any IPCs in order to avoid deadlocks. This patch
sets the unblock flag to false for all renderer->GPU IPCs to preserve order, and
adds some more DCHECK()s to enforce that the GPU process does not send any sync
IPCs out to other processes.
BUG=84065
TEST=
Review URL: http://codereview.chromium.org/7104014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87427 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/gpu/gpu_child_thread.cc')
| -rw-r--r-- | content/gpu/gpu_child_thread.cc | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/content/gpu/gpu_child_thread.cc b/content/gpu/gpu_child_thread.cc index b84ac0f..ec62d13 100644 --- a/content/gpu/gpu_child_thread.cc +++ b/content/gpu/gpu_child_thread.cc @@ -86,12 +86,8 @@ void GpuChildThread::Init(const base::Time& process_start_time) { bool GpuChildThread::Send(IPC::Message* msg) { // The GPU process must never send a synchronous IPC message to the browser - // process. This could result in deadlock. Unfortunately linux does this for - // GpuHostMsg_ResizeXID. TODO(apatrick): fix this before issuing any GL calls - // on the browser process' GPU thread. -#if !defined(TOOLKIT_USES_GTK) - DCHECK(!msg->is_sync()); -#endif + // process. This could result in deadlock. + DCHECK(!msg->is_sync()); return ChildThread::Send(msg); } |