Fix bad section object leak when painting plugins

The skia canvas does not own the section handle in: PlatformCanvas::initialize(x, y, true, section)
so you have close it at some point.

Since skia calls CreateDibSection in this fuction, which maps the memory, it is safe to close the
handle after initialize. A test is being added to ui_tests to make sure we know if this works.


BUG=31173
TEST= see http://codereview.chromium.org/7492074/
Review URL: http://codereview.chromium.org/7482047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94604 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 7 insertions, 3 deletions

diff --git a/content/plugin/webplugin_proxy.cc b/content/plugin/webplugin_proxy.cc
index a54f73a..9b34568 100644
--- a/content/plugin/webplugin_proxy.cc
+++ b/content/plugin/webplugin_proxy.cc
@@ -469,16 +469,20 @@ void WebPluginProxy::CreateCanvasFromHandle(
   // Create a canvas that will reference the shared bits. We have to handle
   // errors here since we're mapping a large amount of memory that may not fit
   // in our address space, or go wrong in some other way.
+  HANDLE section = chrome::GetSectionFromProcess(dib_handle,
+                                                 channel_->renderer_handle(),
+                                                 false);
   scoped_ptr<skia::PlatformCanvas> canvas(new skia::PlatformCanvas);
   if (!canvas->initialize(
           window_rect.width(),
           window_rect.height(),
           true,
-          chrome::GetSectionFromProcess(dib_handle,
-              channel_->renderer_handle(), false))) {
-    canvas.reset();
+          section)) {
+    canvas_out->reset();
   }
   canvas_out->reset(canvas.release());
+  // The canvas does not own the section so we need to close it now.
+  CloseHandle(section);
 }
 
 void WebPluginProxy::SetWindowlessBuffers(