diff options
| author | xhwang@chromium.org <xhwang@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-07 11:05:56 +0000 |
|---|---|---|
| committer | xhwang@chromium.org <xhwang@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-07 11:05:56 +0000 |
| commit | 8bc550e6431143206cffdf10168a74521b29946c (patch) | |
| tree | 8d093fc77d449d0b10cde27acfae3856d15bb51a /content/ppapi_plugin | |
| parent | f321114d12599737f245da4fb12f8552f8d83c1c (diff) | |
| download | chromium_src-8bc550e6431143206cffdf10168a74521b29946c.zip chromium_src-8bc550e6431143206cffdf10168a74521b29946c.tar.gz chromium_src-8bc550e6431143206cffdf10168a74521b29946c.tar.bz2 | |
Removed CHECKs used for bug investigation.
CHECKs was added when investigating issue 103957 and issue 95732. Since these two bugs have been fixed, remove CHECKs or replace with normal error handling.
BUG=95732,103957
TEST=none
Review URL: http://codereview.chromium.org/9307009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120763 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/ppapi_plugin')
| -rw-r--r-- | content/ppapi_plugin/ppapi_thread.cc | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/content/ppapi_plugin/ppapi_thread.cc b/content/ppapi_plugin/ppapi_thread.cc index 154826c..8ef6d6b 100644 --- a/content/ppapi_plugin/ppapi_thread.cc +++ b/content/ppapi_plugin/ppapi_thread.cc @@ -238,9 +238,6 @@ void PpapiThread::OnMsgCreateChannel(base::ProcessHandle host_process_handle, if (!library_.is_valid() || // Plugin couldn't be loaded. !SetupRendererChannel(host_process_handle, renderer_id, &channel_handle)) { - // TODO(xhwang): Add CHECK to investigate the root cause of - // crbug.com/103957. Will remove after the bug is fixed. - CHECK(!is_broker_ || library_.is_valid()); Send(new PpapiHostMsg_ChannelCreated(IPC::ChannelHandle())); return; } @@ -310,9 +307,6 @@ bool PpapiThread::SetupRendererChannel(base::ProcessHandle host_process_handle, // This ensures this process will be notified when it is closed even if a // connection is not established. handle->socket = base::FileDescriptor(dispatcher->TakeRendererFD(), true); - // Check the validity of fd for bug investigation. Remove after fixed. - // See for details: crbug.com/103957. - CHECK_NE(-1, handle->socket.fd); if (handle->socket.fd == -1) return false; #endif |