diff options
| author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-11 05:41:40 +0000 |
|---|---|---|
| committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-11 05:41:40 +0000 |
| commit | 99907365ccdfb821ab0c34e36dadcb26ce25f20e (patch) | |
| tree | 8676bbe1bfebcf35c0f71d31b06b2c9f1e2afb6f /content/public/browser/browser_main_parts.h | |
| parent | 57b8bb357db85d85157c3a87f0b87383343867d8 (diff) | |
| download | chromium_src-99907365ccdfb821ab0c34e36dadcb26ce25f20e.zip chromium_src-99907365ccdfb821ab0c34e36dadcb26ce25f20e.tar.gz chromium_src-99907365ccdfb821ab0c34e36dadcb26ce25f20e.tar.bz2 | |
Move creation and ownership of ResourceDispatcherHost and PluginService to content. This gives a few benefits:
-avoid having each embedder know when to create/destruct these objects, as well as contained objects (i.e. those related to downloads)
-avoid having to tell embedders about specifics of BrowserThread startup/shutdown
-move ResourceDispatcherHost's getter to content where it belongs
I've taken out the DnsParallelism field trial (not used anymore, confirmed with jar) as it was the only thing that caused MetricsService to depend on IOThread initialization, which also depended on MetricsService (through FieldTrials). This two-sided dependency always annoyed me and made the code hard to restructure.
BUG=98716
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117078
Review URL: http://codereview.chromium.org/9150016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117171 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/public/browser/browser_main_parts.h')
| -rw-r--r-- | content/public/browser/browser_main_parts.h | 17 |
1 files changed, 0 insertions, 17 deletions
diff --git a/content/public/browser/browser_main_parts.h b/content/public/browser/browser_main_parts.h index 4bce3cf..09cf20a 100644 --- a/content/public/browser/browser_main_parts.h +++ b/content/public/browser/browser_main_parts.h @@ -72,15 +72,6 @@ class CONTENT_EXPORT BrowserMainParts { // been run), and the toolkit has been initialized. virtual void PreCreateThreads() = 0; - // Called once for each thread owned by the content framework just - // before and just after the thread object is created and started. - // This happens in the order of the threads' appearence in the - // BrowserThread::ID enumeration. Note that there will be no such - // call for BrowserThread::UI, since it is the main thread of the - // application. - virtual void PreStartThread(BrowserThread::ID identifier) = 0; - virtual void PostStartThread(BrowserThread::ID identifier) = 0; - // This is called just before the main message loop is run. The // various browser threads have all been created at this point virtual void PreMainMessageLoopRun() = 0; @@ -94,14 +85,6 @@ class CONTENT_EXPORT BrowserMainParts { // threads are stopped. virtual void PostMainMessageLoopRun() = 0; - // Called once for each thread owned by the content framework just - // before and just after it is torn down. This is in reverse order - // of the threads' appearance in the BrowserThread::ID enumeration. - // Note that you will not receive such a call for BrowserThread::UI, - // since it is the main thread of the application. - virtual void PreStopThread(BrowserThread::ID identifier) = 0; - virtual void PostStopThread(BrowserThread::ID identifier) = 0; - // Called as the very last part of shutdown, after threads have been // stopped and destroyed. virtual void PostDestroyThreads() = 0; |