diff options
| author | fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-09 20:58:41 +0000 |
|---|---|---|
| committer | fsamuel@chromium.org <fsamuel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-09 20:58:41 +0000 |
| commit | fa4d91939c2e7df3e1667dfe2e01f61719543eb0 (patch) | |
| tree | 8f8102c283ea573acd2d8afa8f3c828f659d95f5 /content/public/browser/browser_plugin_guest_delegate.h | |
| parent | 138f97e92ef1b23b7788616605a74e1840cf44d9 (diff) | |
| download | chromium_src-fa4d91939c2e7df3e1667dfe2e01f61719543eb0.zip chromium_src-fa4d91939c2e7df3e1667dfe2e01f61719543eb0.tar.gz chromium_src-fa4d91939c2e7df3e1667dfe2e01f61719543eb0.tar.bz2 | |
<webview>: Cleanup WebRequest event listeners when embedder destroyed
<webivew> WebRequest event listeners should survive reparenting of the <webview> within the same embedder WebContents. Currently, event listeners are lost when the <webview> is removed from the DOM. This CL solves this problem.
Note that there is still a problem where custom elements break if the original page that created the element is closed. I have written a test that exercises this problem and I've left the test disabled until we fix the problem.
BUG=281551
Test=WebViewTest.Shim_TestWebRequestListenerSurvivesReparenting
Review URL: https://chromiumcodereview.appspot.com/23514016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222090 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/public/browser/browser_plugin_guest_delegate.h')
| -rw-r--r-- | content/public/browser/browser_plugin_guest_delegate.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/content/public/browser/browser_plugin_guest_delegate.h b/content/public/browser/browser_plugin_guest_delegate.h index c7a18c6..9500c0c 100644 --- a/content/public/browser/browser_plugin_guest_delegate.h +++ b/content/public/browser/browser_plugin_guest_delegate.h @@ -39,6 +39,9 @@ class CONTENT_EXPORT BrowserPluginGuestDelegate { // gracefully. virtual void GuestProcessGone(base::TerminationStatus status) {} + // Informs the delegate that the embedder has been destroyed. + virtual void EmbedderDestroyed() {} + virtual bool HandleKeyboardEvent(const NativeWebKeyboardEvent& event); // Notification that a load in the guest resulted in abort. Note that |url| |