diff options
author | kbr@chromium.org <kbr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-13 18:09:34 +0000 |
---|---|---|
committer | kbr@chromium.org <kbr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-13 18:09:34 +0000 |
commit | c5cba4cb2c4eceda230f8e6a07121285725bff3a (patch) | |
tree | 8b785a6fcc05e4ba84659de5428213d0b52e2f32 /content/public/browser/gpu_data_manager_observer.h | |
parent | 3f345fd7297957b3ebefbdf77c384bc2e10fdd7b (diff) | |
download | chromium_src-c5cba4cb2c4eceda230f8e6a07121285725bff3a.zip chromium_src-c5cba4cb2c4eceda230f8e6a07121285725bff3a.tar.gz chromium_src-c5cba4cb2c4eceda230f8e6a07121285725bff3a.tar.bz2 |
Revert 199530 "Refactor GpuDataManagerImpl to make it thread-saf..."
Caused browser process crashes on dual-GPU Macs.
> Refactor GpuDataManagerImpl to make it thread-safe, now and forever.
>
> The original impl of GpuDataManagerImpl is thread-safe, but gradurally it regressed.
>
> In order to make sure this class is thread-safe in the future, we move all code to GpuDataManagerImplPrivate, and make GpuDataManagerImpl a simple wrapper around GpuDataManagerImplPrivate's public functions, where each function call is guarded by lock, thus thread-safe.
>
> BUG=232556
> TEST=asan bots no longer crashes as described in crbug.com/232556
> R=joi@chromium.org, kbr@chromium.org, piman@chromium.org
>
> Review URL: https://codereview.chromium.org/14794006
TBR=zmo@chromium.org
Review URL: https://codereview.chromium.org/15043006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199770 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/public/browser/gpu_data_manager_observer.h')
-rw-r--r-- | content/public/browser/gpu_data_manager_observer.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/content/public/browser/gpu_data_manager_observer.h b/content/public/browser/gpu_data_manager_observer.h index 53989fe..4ed348e 100644 --- a/content/public/browser/gpu_data_manager_observer.h +++ b/content/public/browser/gpu_data_manager_observer.h @@ -35,9 +35,6 @@ class GpuDataManagerObserver { // Called for any observer when the GPU process crashed. virtual void OnGpuProcessCrashed(base::TerminationStatus exit_code) {} - // Called for any observer when the system switches to a different GPU. - virtual void OnGpuSwitching() {} - protected: virtual ~GpuDataManagerObserver() {} }; |