diff options
| author | lazyboy@chromium.org <lazyboy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-10 19:03:41 +0000 |
|---|---|---|
| committer | lazyboy@chromium.org <lazyboy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-10-10 19:03:41 +0000 |
| commit | 538941221fc5518ed459d1239968a2fc7da8c257 (patch) | |
| tree | f8b8b443687ce3a36974c7f2a0fbbacc48fb7105 /content/public/common/content_switches.h | |
| parent | 0737ea62f7d1c51b44b59824c66fb428382df880 (diff) | |
| download | chromium_src-538941221fc5518ed459d1239968a2fc7da8c257.zip chromium_src-538941221fc5518ed459d1239968a2fc7da8c257.tar.gz chromium_src-538941221fc5518ed459d1239968a2fc7da8c257.tar.bz2 | |
<browser> Disable browser plugin in content_shell by default.
This means I had to move the flag that forcefully enables browser plugin everywhere from chrome/ to content/.
Reasoning for the change:
Enabling browser plugin in regular pages (other than apps), breaks same origin policy: The embedder is allowed to inject javascript: URLs into the browser plugin, and it will soon be able to call executeScript. That means the embedder can do whatever it wants with the guest.
The concern is also true for content_shell, since anyone who embeds Chrome is facing a similar risk if they don't disable the browser plugin.
BUG=154360
TEST=Tested with content_shell, by default browser plugin doesn't load anymore. content_browsertests would also not run, made the change to enable them.
Ran Tests:
content_browsertests:BrowserPluginHostTest*
content_browsertests:BrowserPluginTest*
browser_tests:BrowserTag*
Review URL: https://chromiumcodereview.appspot.com/11035070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161142 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/public/common/content_switches.h')
| -rw-r--r-- | content/public/common/content_switches.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/content/public/common/content_switches.h b/content/public/common/content_switches.h index 265a164..fe46833 100644 --- a/content/public/common/content_switches.h +++ b/content/public/common/content_switches.h @@ -91,6 +91,7 @@ CONTENT_EXPORT extern const char kEnableAcceleratedPainting[]; CONTENT_EXPORT extern const char kEnableAcceleratedFilters[]; extern const char kEnableAcceleratedPlugins[]; extern const char kEnableAccessibilityLogging[]; +CONTENT_EXPORT extern const char kEnableBrowserPluginForAllViewTypes[]; extern const char kEnableBrowserPluginOldImplementation[]; CONTENT_EXPORT extern const char kEnableCompositingForFixedPosition[]; extern const char kEnableCssShaders[]; |