diff options
| author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-27 23:47:11 +0000 |
|---|---|---|
| committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-27 23:47:11 +0000 |
| commit | bb37b653d232b2d1dd7be87e90b37d3887906d9f (patch) | |
| tree | 8e660d76c5b9ed12247910b1f8efc1e931212c60 /content/public/renderer | |
| parent | 8f2e33582ae9f4752893741772c7fac4e72915b7 (diff) | |
| download | chromium_src-bb37b653d232b2d1dd7be87e90b37d3887906d9f.zip chromium_src-bb37b653d232b2d1dd7be87e90b37d3887906d9f.tar.gz chromium_src-bb37b653d232b2d1dd7be87e90b37d3887906d9f.tar.bz2 | |
Ensure that the OSK on Windows 8 shows up when we tap on an editable field in any WebContents.
The current implementation was displaying the OSK only when we tapped on a WebContents hosted by a Browser window. This
relied on the ChromeRenderViewObserver object in the renderer sending an IPC message ChromeViewHostMsg_FocusedNodeTouched
which is handled by the Chrome browser code via a WebContentsObserver implementation.
Based on discussions with jam and comments from avi in the review, we decided to implement this functionality in content.
Fixes are as below:-
1. We have a new IPc message ViewHostMsg_FocusedNodeTouched which is defined in the view_messages.h file.
2. This IPC is sent by the RenderViewImpl::didHandleGestureEvent method if we tapped on an editable field.
3, This IPC is handled by the RenderViewHostImpl class. We display the OSK on Windows 8 Aura if a focused editable
node was tapped.
4. The ChromeViewHostMsg_FocusedNodeTouched IPC has been deleted along with the didHandleGestureEvent method in the
RenderViewObserver interface.
BUG=321576, 319219
R=jam@chromium.org, palmer@chromium.org, jam
TBR=jschuh
Review URL: https://codereview.chromium.org/89873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237646 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/public/renderer')
| -rw-r--r-- | content/public/renderer/render_view_observer.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/content/public/renderer/render_view_observer.h b/content/public/renderer/render_view_observer.h index f3d1094..b41765b 100644 --- a/content/public/renderer/render_view_observer.h +++ b/content/public/renderer/render_view_observer.h @@ -94,7 +94,6 @@ class CONTENT_EXPORT RenderViewObserver : public IPC::Listener, // These match the RenderView methods. virtual void DidHandleMouseEvent(const blink::WebMouseEvent& event) {} virtual void DidHandleTouchEvent(const blink::WebTouchEvent& event) {} - virtual void DidHandleGestureEvent(const blink::WebGestureEvent& event) {} virtual void DidCreatePepperPlugin(RendererPpapiHost* host) {} // Called when we receive a console message from WebKit for which we requested |