diff options
| author | creis@chromium.org <creis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-27 21:22:14 +0000 |
|---|---|---|
| committer | creis@chromium.org <creis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-27 21:22:14 +0000 |
| commit | 434bc9bd7fa0f3d22381e467d35ddb34b2a2c1ac (patch) | |
| tree | 295f18e66f31723fca363e34547a0e2ac992577d /content/public/renderer | |
| parent | 006128072c1334a8bd8c8658fcd8a5bb280151f9 (diff) | |
| download | chromium_src-434bc9bd7fa0f3d22381e467d35ddb34b2a2c1ac.zip chromium_src-434bc9bd7fa0f3d22381e467d35ddb34b2a2c1ac.tar.gz chromium_src-434bc9bd7fa0f3d22381e467d35ddb34b2a2c1ac.tar.bz2 | |
Remove unused opener_url from DidStartProvisionalLoad.
The value is unused and potentially incorrect, leading to problems in the
browser process.
BUG=143155
TEST=kSwappedOutURL DCHECK in FilterURL doesn't fire.
Review URL: https://chromiumcodereview.appspot.com/11299019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169756 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/public/renderer')
| -rw-r--r-- | content/public/renderer/content_renderer_client.cc | 2 | ||||
| -rw-r--r-- | content/public/renderer/content_renderer_client.h | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/content/public/renderer/content_renderer_client.cc b/content/public/renderer/content_renderer_client.cc index baf3240..a62995f 100644 --- a/content/public/renderer/content_renderer_client.cc +++ b/content/public/renderer/content_renderer_client.cc @@ -56,7 +56,7 @@ bool ContentRendererClient::RunIdleHandlerWhenWidgetsHidden() { return true; } -bool ContentRendererClient::AllowPopup(const GURL& creator) { +bool ContentRendererClient::AllowPopup() { return false; } diff --git a/content/public/renderer/content_renderer_client.h b/content/public/renderer/content_renderer_client.h index f12b29a..06ad7c3 100644 --- a/content/public/renderer/content_renderer_client.h +++ b/content/public/renderer/content_renderer_client.h @@ -133,8 +133,8 @@ class CONTENT_EXPORT ContentRendererClient { // all widgets are hidden. virtual bool RunIdleHandlerWhenWidgetsHidden(); - // Returns true if the given url can create popup windows. - virtual bool AllowPopup(const GURL& creator); + // Returns true if a popup window should be allowed. + virtual bool AllowPopup(); // Returns true if the navigation was handled by the embedder and should be // ignored by WebKit. This method is used by CEF. |