summaryrefslogtreecommitdiffstats
path: root/content/renderer/render_view_browsertest.cc
diff options
context:
space:
mode:
authorcreis@chromium.org <creis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-06-14 07:27:28 +0000
committercreis@chromium.org <creis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-06-14 07:27:28 +0000
commite198683d045842e9da6cd5ce53b4f3c690ad2070 (patch)
tree8a134325ba972af789a39623dbd9e674f429ce47 /content/renderer/render_view_browsertest.cc
parent00464e4f3f8286cc1265db6b0dfc61cc40b94932 (diff)
downloadchromium_src-e198683d045842e9da6cd5ce53b4f3c690ad2070.zip
chromium_src-e198683d045842e9da6cd5ce53b4f3c690ad2070.tar.gz
chromium_src-e198683d045842e9da6cd5ce53b4f3c690ad2070.tar.bz2
Eliminate SwapOut message parameters, keeping state in RVHM instead.
We no longer need to process SwapOut messages on the IO thread, and we no longer pass browser-internal request IDs to the renderer to be echoed back. This paves the way to support transferring navigations using CrossSiteResourceHandler. BUG=238331 TEST=No behavior change. Review URL: https://chromiumcodereview.appspot.com/15682009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206354 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/renderer/render_view_browsertest.cc')
-rw-r--r--content/renderer/render_view_browsertest.cc25
1 files changed, 4 insertions, 21 deletions
diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc
index d964fbe..f412f72 100644
--- a/content/renderer/render_view_browsertest.cc
+++ b/content/renderer/render_view_browsertest.cc
@@ -425,32 +425,20 @@ TEST_F(RenderViewImplTest, SendSwapOutACK) {
int initial_page_id = view()->GetPageId();
// Respond to a swap out request.
- ViewMsg_SwapOut_Params params;
- params.closing_process_id = 10;
- params.closing_route_id = 11;
- params.new_render_process_host_id = 12;
- params.new_request_id = 13;
- view()->OnSwapOut(params);
+ view()->OnSwapOut();
// Ensure the swap out commits synchronously.
EXPECT_NE(initial_page_id, view()->GetPageId());
- // Check for a valid OnSwapOutACK with echoed params.
+ // Check for a valid OnSwapOutACK.
const IPC::Message* msg = render_thread_->sink().GetUniqueMessageMatching(
ViewHostMsg_SwapOut_ACK::ID);
ASSERT_TRUE(msg);
- ViewHostMsg_SwapOut_ACK::Param reply_params;
- ViewHostMsg_SwapOut_ACK::Read(msg, &reply_params);
- EXPECT_EQ(params.closing_process_id, reply_params.a.closing_process_id);
- EXPECT_EQ(params.closing_route_id, reply_params.a.closing_route_id);
- EXPECT_EQ(params.new_render_process_host_id,
- reply_params.a.new_render_process_host_id);
- EXPECT_EQ(params.new_request_id, reply_params.a.new_request_id);
// It is possible to get another swap out request. Ensure that we send
// an ACK, even if we don't have to do anything else.
render_thread_->sink().ClearMessages();
- view()->OnSwapOut(params);
+ view()->OnSwapOut();
const IPC::Message* msg2 = render_thread_->sink().GetUniqueMessageMatching(
ViewHostMsg_SwapOut_ACK::ID);
ASSERT_TRUE(msg2);
@@ -505,12 +493,7 @@ TEST_F(RenderViewImplTest, ReloadWhileSwappedOut) {
ProcessPendingMessages();
// Respond to a swap out request.
- ViewMsg_SwapOut_Params params;
- params.closing_process_id = 10;
- params.closing_route_id = 11;
- params.new_render_process_host_id = 12;
- params.new_request_id = 13;
- view()->OnSwapOut(params);
+ view()->OnSwapOut();
// Check for a OnSwapOutACK.
const IPC::Message* msg = render_thread_->sink().GetUniqueMessageMatching(