diff options
author | csilv@chromium.org <csilv@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-22 02:59:01 +0000 |
---|---|---|
committer | csilv@chromium.org <csilv@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-22 02:59:01 +0000 |
commit | 0f083403ad489e6fd3305c540e14ea6c9a460061 (patch) | |
tree | aab6a4a6772cc76c6389aa45c64b4339398365e9 /content/renderer/render_view_impl.cc | |
parent | 8caadebcb838083821519861da751992401ce0fe (diff) | |
download | chromium_src-0f083403ad489e6fd3305c540e14ea6c9a460061.zip chromium_src-0f083403ad489e6fd3305c540e14ea6c9a460061.tar.gz chromium_src-0f083403ad489e6fd3305c540e14ea6c9a460061.tar.bz2 |
Page zoom improvements:
1. Change from using zoom levels to a range of preset zoom factors (percentages). Zoom levels are the values that WebKit uses for page zoom. While zoom levels are simple to implement, they result in undesirable percentages like 57%, 144%, 207%, etc. Changing to zoom factors gives us user-friendly zoom percentages.
2. Increase the range of supported zoom values. A user can now zoom between 25% to 500%.
3. Use an epsilon value when comparing zoom floating point values. The previous version was doing an equality comparison of double values which may not always work as expected.
BUG=71484
TEST=Exercise zoom in/out via the wrench menu; exercise default page zoom setting in options window
Review URL: http://codereview.chromium.org/8528011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111087 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/renderer/render_view_impl.cc')
-rw-r--r-- | content/renderer/render_view_impl.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc index 7eeaa8d..244bf8b 100644 --- a/content/renderer/render_view_impl.cc +++ b/content/renderer/render_view_impl.cc @@ -1111,8 +1111,8 @@ void RenderViewImpl::UpdateURL(WebFrame* frame) { // will also call us back which will cause us to send a message to // update TabContents. webview()->zoomLimitsChanged( - WebView::zoomFactorToZoomLevel(WebView::minTextSizeMultiplier), - WebView::zoomFactorToZoomLevel(WebView::maxTextSizeMultiplier)); + WebView::zoomFactorToZoomLevel(content::kMinimumZoomFactor), + WebView::zoomFactorToZoomLevel(content::kMaximumZoomFactor)); // Update contents MIME type for main frame. params.contents_mime_type = ds->response().mimeType().utf8(); |