diff options
author | rtenneti@chromium.org <rtenneti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-28 21:58:18 +0000 |
---|---|---|
committer | rtenneti@chromium.org <rtenneti@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-28 21:58:18 +0000 |
commit | ecaae0a04cad41f2bc59a2a5671d6f9cdf82de99 (patch) | |
tree | 37a78aa07506eaf4d3183a3e6bb47ac40bdb95ff /content/renderer/render_view_impl.h | |
parent | 4afc8d67c4d6491fe1e1d60d17fa6651e861e795 (diff) | |
download | chromium_src-ecaae0a04cad41f2bc59a2a5671d6f9cdf82de99.zip chromium_src-ecaae0a04cad41f2bc59a2a5671d6f9cdf82de99.tar.gz chromium_src-ecaae0a04cad41f2bc59a2a5671d6f9cdf82de99.tar.bz2 |
Revert 202620 "Collect tab timing information for use in telemen..."
> Collect tab timing information for use in telementry-based startup tests
>
> Motivation: Data collection exposed in this CL is needed by upcoming startup tests we're writing using Telemtry.
>
> Expose a new window.statsCollectionController object to JS and move existing histogram reading code into it since that seemed misplaced in DOMAutomationController.
>
> Add a new --enable-stats-collection-bindings to activate said object.
>
> Example usage in telemtry:
> with browser.Create() as b:
> b.tabs[0].Navigate("http://www.google.com")
> b.tabs[0].WaitForDocumentReadyStateToBeComplete()
> print b.tabs[0].EvaluateJavaScript('statsCollectionController.tabLoadTiming()')
>
> BUG=None
>
> Review URL: https://chromiumcodereview.appspot.com/12389073
TBR=jeremy@chromium.org
Review URL: https://codereview.chromium.org/16160006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202662 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/renderer/render_view_impl.h')
-rw-r--r-- | content/renderer/render_view_impl.h | 18 |
1 files changed, 2 insertions, 16 deletions
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h index 39734b4..3bef002 100644 --- a/content/renderer/render_view_impl.h +++ b/content/renderer/render_view_impl.h @@ -38,7 +38,6 @@ #include "content/renderer/render_view_pepper_helper.h" #include "content/renderer/render_widget.h" #include "content/renderer/renderer_webcookiejar_impl.h" -#include "content/renderer/stats_collection_observer.h" #include "ipc/ipc_platform_file.h" #include "third_party/WebKit/Source/Platform/chromium/public/WebFileSystem.h" #include "third_party/WebKit/Source/Platform/chromium/public/WebGraphicsContext3D.h" @@ -165,7 +164,6 @@ class RendererPpapiHost; class RendererWebColorChooserImpl; class RenderWidgetFullscreenPepper; class SpeechRecognitionDispatcher; -class StatsCollectionController; class WebPluginDelegateProxy; struct CustomContextMenuContext; struct FaviconURL; @@ -269,12 +267,6 @@ class CONTENT_EXPORT RenderViewImpl void AddObserver(RenderViewObserver* observer); void RemoveObserver(RenderViewObserver* observer); - // Returns the StatsCollectionObserver associated with this view, or NULL - // if one wasn't created; - StatsCollectionObserver* GetStatsCollectionObserver() { - return stats_collection_observer_.get(); - } - // Adds the given file chooser request to the file_chooser_completion_ queue // (see that var for more) and requests the chooser be displayed if there are // no other waiting items in the queue. @@ -1530,20 +1522,14 @@ class CONTENT_EXPORT RenderViewImpl // DOM automation bindings are enabled. scoped_ptr<DomAutomationController> dom_automation_controller_; - // Allows JS to read out a variety of internal various metrics. The JS object - // is only exposed when the stats collection bindings are enabled. - scoped_ptr<StatsCollectionController> stats_collection_controller_; - // This field stores drag/drop related info for the event that is currently // being handled. If the current event results in starting a drag/drop // session, this info is sent to the browser along with other drag/drop info. DragEventSourceInfo possible_drag_event_info_; - // NOTE: pepper_helper_ and stats_collection_observer_ should be the last - // members because their constructors call the AddObservers method of - // RenderViewImpl. + // NOTE: pepper_helper_ should be last member because its constructor calls + // AddObservers method of RenderViewImpl from c-tor. scoped_ptr<RenderViewPepperHelper> pepper_helper_; - scoped_ptr<StatsCollectionObserver> stats_collection_observer_; // --------------------------------------------------------------------------- // ADDING NEW DATA? Please see if it fits appropriately in one of the above |