summaryrefslogtreecommitdiffstats
path: root/content/renderer/render_view_impl.h
diff options
context:
space:
mode:
authorboliu@chromium.org <boliu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-03-08 00:31:01 +0000
committerboliu@chromium.org <boliu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-03-08 00:31:01 +0000
commit2985ed758610fb7d6d3a8d2400328d3ad7383fca (patch)
tree5f4873df3edd23b5e46702fc758da989a62a650e /content/renderer/render_view_impl.h
parenta9f94bc6fc85c5d406035402e116f1ae29b0b675 (diff)
downloadchromium_src-2985ed758610fb7d6d3a8d2400328d3ad7383fca.zip
chromium_src-2985ed758610fb7d6d3a8d2400328d3ad7383fca.tar.gz
chromium_src-2985ed758610fb7d6d3a8d2400328d3ad7383fca.tar.bz2
Remove Android WebView synchronous find.
After the browser UI thread and the renderer compositor threads are merged, all synchronous calls from UI to renderer will possible deadlocks since the renderer webkit thread blocks on the compositor thread all the time. Therefore remove support for synchronous find in page which is already an deprecated API. BUG=179436 TBR=palmer@chromium.org (Only removing ipc message) Review URL: https://chromiumcodereview.appspot.com/12383030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186827 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/renderer/render_view_impl.h')
-rw-r--r--content/renderer/render_view_impl.h20
1 files changed, 0 insertions, 20 deletions
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h
index 80b4c21..c11df2c 100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -1065,10 +1065,6 @@ class CONTENT_EXPORT RenderViewImpl
void OnFindMatchRects(int current_version);
void OnSelectPopupMenuItems(bool canceled,
const std::vector<int>& selected_indices);
- void OnSynchronousFind(int request_id,
- const string16& search_string,
- const WebKit::WebFindOptions& options,
- IPC::Message* reply_msg);
void OnUndoScrollFocusedEditableNodeIntoRect();
void OnEnableHidingTopControls(bool enable);
#elif defined(OS_MACOSX)
@@ -1140,11 +1136,6 @@ class CONTENT_EXPORT RenderViewImpl
// doesn't have a frame at the specified size, the first is returned.
bool DownloadFavicon(int id, const GURL& image_url, int image_size);
- // Starts a new find-in-page search or looks for the next match.
- void Find(int request_id,
- const string16& search_text,
- const WebKit::WebFindOptions& options);
-
GURL GetAlternateErrorPageURL(const GURL& failed_url,
ErrorPageType error_type);
@@ -1205,9 +1196,6 @@ class CONTENT_EXPORT RenderViewImpl
// Starts nav_state_sync_timer_ if it isn't already running.
void StartNavStateSyncTimerIfNecessary();
- // Stops the current find-in-page search.
- void StopFinding(StopFindAction action);
-
// Dispatches the current state of selection on the webpage to the browser if
// it has changed.
// TODO(varunjain): delete this method once we figure out how to keep
@@ -1500,14 +1488,6 @@ class CONTENT_EXPORT RenderViewImpl
// created in the renderer process.
scoped_ptr<webkit_media::MediaPlayerBridgeManagerImpl> media_bridge_manager_;
- // Holds the message used to return find results to the browser during
- // synchronous find-in-page requests. Only non-null during these requests.
- scoped_ptr<IPC::Message> synchronous_find_reply_message_;
-
- // The active find-in-page match ordinal during synchronous requests.
- // Needed to be remembered across WebKit callbacks.
- int synchronous_find_active_match_ordinal_;
-
// A date/time picker object for date and time related input elements.
scoped_ptr<RendererDateTimePicker> date_time_picker_client_;
#endif