diff options
| author | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-10 17:18:53 +0000 |
|---|---|---|
| committer | joi@chromium.org <joi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-10 17:18:53 +0000 |
| commit | edafd4c1a5c906e808e2448810e2099d8dc704b9 (patch) | |
| tree | 4ccc930c0b9ff8663183ebb6333e9ac990f0e491 /content/renderer/renderer_main.cc | |
| parent | 063bb25a11a9258c44d61210dfd98f41e7b4f24a (diff) | |
| download | chromium_src-edafd4c1a5c906e808e2448810e2099d8dc704b9.zip chromium_src-edafd4c1a5c906e808e2448810e2099d8dc704b9.tar.gz chromium_src-edafd4c1a5c906e808e2448810e2099d8dc704b9.tar.bz2 | |
Add one-time randomization support for FieldTrial, and the ability to
disable field trials. I am going to have a need for both soon.
Update some documentation about empty trial names, add TrialExists() method and update many call-sites to use this (it simplifies the previous logic which checked for existence and then for non-empty name, which can no longer happen).
Refactor a bit in browser_main.
While I'm in there and needing base/OWNERS approval, add an OWNERS
file for base/metrics that adds jar@chromium.org as an owner for that
directory.
Initially committed as r84197.
Rolled back due to DCHECK in official builds, r84373.
Will re-submit with fix.
BUG=81750
TEST=base_unittests
Review URL: http://codereview.chromium.org/6883102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84801 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/renderer/renderer_main.cc')
| -rw-r--r-- | content/renderer/renderer_main.cc | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/content/renderer/renderer_main.cc b/content/renderer/renderer_main.cc index e5e6984..36c73ba 100644 --- a/content/renderer/renderer_main.cc +++ b/content/renderer/renderer_main.cc @@ -191,8 +191,10 @@ int RendererMain(const MainFunctionParams& parameters) { statistics.reset(new base::StatisticsRecorder()); } - // Initialize statistical testing infrastructure. - base::FieldTrialList field_trial; + // Initialize statistical testing infrastructure. We set client_id to the + // empty string to disallow the renderer process from creating its own + // one-time randomized trials; they should be created in the browser process. + base::FieldTrialList field_trial(EmptyString()); // Ensure any field trials in browser are reflected into renderer. if (parsed_command_line.HasSwitch(switches::kForceFieldTestNameAndValue)) { std::string persistent = parsed_command_line.GetSwitchValueASCII( |