diff options
| author | dimich@chromium.org <dimich@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-30 23:43:57 +0000 |
|---|---|---|
| committer | dimich@chromium.org <dimich@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-09-30 23:43:57 +0000 |
| commit | 08202909defd4f7890548dc73f1ec4e58fd0aec7 (patch) | |
| tree | 2ebd2551f21c8580acaa2277e8f45627b7dbda85 /content/renderer/text_input_client_observer.cc | |
| parent | e54703d051313d614e1753b4ecff86865d160891 (diff) | |
| download | chromium_src-08202909defd4f7890548dc73f1ec4e58fd0aec7.zip chromium_src-08202909defd4f7890548dc73f1ec4e58fd0aec7.tar.gz chromium_src-08202909defd4f7890548dc73f1ec4e58fd0aec7.tar.bz2 | |
Add a test for panel's Draw Attention feature.
Implemented and verified for linux, mac and win. 2 tests out of 4 are currently disabled because activation story in tests is still not understood by me completely, I'm going to continue fixing it. This patch fixes 2 issues with activation (implements it on Mac and properly waits for it on Linux)
Pieces of this patch:
1. Added NativePanelTesting::VerifyDrawingAttention() that does platform-specific 'deep verification' if the panel indeed shows 'draw attention' decorations.
2. Added NOTIFICATION_PANEL_CHANGED_ACTIVE_STATUS notification which is fired when a panel is transitioning active<->inactive. This allows to wait for activation, which is especially useful in GTK and Mac case, where gaining/loosing focus can involve cross-process interactions and thus running local loop is not enough.
3. Implemented Show()/ShowInactive() on Mac so they correspond to their names.
4. Implemented 4 tests, 2 of them currently enabled. Will enable more in a subsequent patch.
Review URL: http://codereview.chromium.org/8072017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103583 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/renderer/text_input_client_observer.cc')
0 files changed, 0 insertions, 0 deletions