diff options
author | dmazzoni@google.com <dmazzoni@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-07 05:26:46 +0000 |
---|---|---|
committer | dmazzoni@google.com <dmazzoni@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-07 05:26:46 +0000 |
commit | 39f10bd4728af6571bc1ac72e53ea5ff584c3d93 (patch) | |
tree | 5e18a90d0825a2f4afb251ff20795c6bc8c6e6aa /content/renderer/v8_value_converter_impl.h | |
parent | 33011ae92c7774a4e5c252a8721b8f5338dc2567 (diff) | |
download | chromium_src-39f10bd4728af6571bc1ac72e53ea5ff584c3d93.zip chromium_src-39f10bd4728af6571bc1ac72e53ea5ff584c3d93.tar.gz chromium_src-39f10bd4728af6571bc1ac72e53ea5ff584c3d93.tar.bz2 |
Revert 135602 - Allow serialization of ArrayBuffer params in extension/apps API methods
Caused these three tests to time out - apparently only in debug mode, which
is perhaps why they were not caught by try runs:
INCOMPLETE (5): TtsApiTest.RegisterEngine
INCOMPLETE (6): TtsApiTest.EngineError
INCOMPLETE (7): TtsApiTest.EngineWordCallbacks
Original description:
This changes the V8ValueConverter to do ArrayBuffer<->BinaryValue conversions,
as well as supporting ArrayBufferView subclasses as request parameters (but
not response ones, since that's unnecessary).
Also adds an experimental API for testing ArrayBuffers in request/response
parameters.
This depends on WebKit changes in https://bugs.webkit.org/show_bug.cgi?id=84899
BUG=122675
TEST=Included browser tests should pass
Review URL: http://codereview.chromium.org/10161038
TBR=asargent@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10388002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135618 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/renderer/v8_value_converter_impl.h')
-rw-r--r-- | content/renderer/v8_value_converter_impl.h | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/content/renderer/v8_value_converter_impl.h b/content/renderer/v8_value_converter_impl.h index c43da46..ac6e7b7 100644 --- a/content/renderer/v8_value_converter_impl.h +++ b/content/renderer/v8_value_converter_impl.h @@ -1,4 +1,4 @@ -// Copyright (c) 2012 The Chromium Authors. All rights reserved. +// Copyright (c) 2011 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -10,7 +10,6 @@ #include "content/public/renderer/v8_value_converter.h" namespace base { -class BinaryValue; class DictionaryValue; class ListValue; class Value; @@ -44,16 +43,9 @@ class CONTENT_EXPORT V8ValueConverterImpl : public content::V8ValueConverter { v8::Handle<v8::Value> ToV8Array(const base::ListValue* list) const; v8::Handle<v8::Value> ToV8Object( const base::DictionaryValue* dictionary) const; - v8::Handle<v8::Value> ToArrayBuffer(const base::BinaryValue* value) const; base::Value* FromV8ValueImpl(v8::Handle<v8::Value> value) const; base::ListValue* FromV8Array(v8::Handle<v8::Array> array) const; - - // This will convert objects of type ArrayBuffer or any of the - // ArrayBufferView subclasses. The return value will be NULL if |value| is - // not one of these types. - base::BinaryValue* FromV8Buffer(v8::Handle<v8::Value> value) const; - base::DictionaryValue* FromV8Object(v8::Handle<v8::Object> object) const; // If true, we will convert undefined JavaScript values to null. |