diff options
author | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-09 05:45:17 +0000 |
---|---|---|
committer | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-09 05:45:17 +0000 |
commit | e59558b78e8c6a1b0bd916a724724b638c3c91b6 (patch) | |
tree | 712268a7e9e1cd552f309d89641b2bed5ad06322 /content/renderer/v8_value_converter_impl_unittest.cc | |
parent | 31fcd34da3797bc49160620ef8c94a38652c0587 (diff) | |
download | chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.zip chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.tar.gz chromium_src-e59558b78e8c6a1b0bd916a724724b638c3c91b6.tar.bz2 |
Rewrite std::string("") to std::string(), Linux edition.
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/renderer/v8_value_converter_impl_unittest.cc')
-rw-r--r-- | content/renderer/v8_value_converter_impl_unittest.cc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/content/renderer/v8_value_converter_impl_unittest.cc b/content/renderer/v8_value_converter_impl_unittest.cc index df68e80..1f6b9bf 100644 --- a/content/renderer/v8_value_converter_impl_unittest.cc +++ b/content/renderer/v8_value_converter_impl_unittest.cc @@ -70,7 +70,7 @@ class V8ValueConverterImplTest : public testing::Test { std::string temp; if (!value->GetString(key, &temp)) { ADD_FAILURE(); - return ""; + return std::string(); } return temp; } @@ -80,7 +80,7 @@ class V8ValueConverterImplTest : public testing::Test { value->Get(v8::String::New(key.c_str())).As<v8::String>(); if (temp.IsEmpty()) { ADD_FAILURE(); - return ""; + return std::string(); } v8::String::Utf8Value utf8(temp); return std::string(*utf8, utf8.length()); @@ -90,7 +90,7 @@ class V8ValueConverterImplTest : public testing::Test { std::string temp; if (!value->GetString(static_cast<size_t>(index), &temp)) { ADD_FAILURE(); - return ""; + return std::string(); } return temp; } @@ -99,7 +99,7 @@ class V8ValueConverterImplTest : public testing::Test { v8::Handle<v8::String> temp = value->Get(index).As<v8::String>(); if (temp.IsEmpty()) { ADD_FAILURE(); - return ""; + return std::string(); } v8::String::Utf8Value utf8(temp); return std::string(*utf8, utf8.length()); |