diff options
author | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-25 09:08:19 +0000 |
---|---|---|
committer | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-25 09:08:19 +0000 |
commit | 3690ebe09a8c3cea0fd7d9ece8f5b8d8ebc65c19 (patch) | |
tree | b26f7f81e48a95473eb4af5304301e9d8cd22fb8 /content/renderer | |
parent | eef99b6591d82399096abdcee07dd67359eec036 (diff) | |
download | chromium_src-3690ebe09a8c3cea0fd7d9ece8f5b8d8ebc65c19.zip chromium_src-3690ebe09a8c3cea0fd7d9ece8f5b8d8ebc65c19.tar.gz chromium_src-3690ebe09a8c3cea0fd7d9ece8f5b8d8ebc65c19.tar.bz2 |
Virtual destructors should have virtual keyword.
Make sure user-declared virtual destructors always have the virtual keyword.
The Clang style-check plugin will check for this soon.
No functionality change: virtual is only added
to destructors that are already implicitly virtual.
Also fix a couple of in-line destructor definitions.
BUG=83408
TEST=none
Review URL: http://codereview.chromium.org/7064033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86587 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/renderer')
-rw-r--r-- | content/renderer/audio_message_filter.h | 2 | ||||
-rw-r--r-- | content/renderer/gpu_channel_host.h | 2 | ||||
-rw-r--r-- | content/renderer/indexed_db_dispatcher.h | 2 | ||||
-rw-r--r-- | content/renderer/plugin_channel_host.h | 2 | ||||
-rw-r--r-- | content/renderer/render_process_impl.h | 2 | ||||
-rw-r--r-- | content/renderer/renderer_webidbobjectstore_impl.h | 2 | ||||
-rw-r--r-- | content/renderer/webplugin_delegate_proxy.h | 2 | ||||
-rw-r--r-- | content/renderer/webworker_proxy.h | 2 |
8 files changed, 8 insertions, 8 deletions
diff --git a/content/renderer/audio_message_filter.h b/content/renderer/audio_message_filter.h index 316ac1b..2403e8f 100644 --- a/content/renderer/audio_message_filter.h +++ b/content/renderer/audio_message_filter.h @@ -53,7 +53,7 @@ class AudioMessageFilter : public IPC::ChannelProxy::MessageFilter { }; explicit AudioMessageFilter(int32 route_id); - ~AudioMessageFilter(); + virtual ~AudioMessageFilter(); // Add a delegate to the map and return id of the entry. int32 AddDelegate(Delegate* delegate); diff --git a/content/renderer/gpu_channel_host.h b/content/renderer/gpu_channel_host.h index ba7ec84..7e67da8 100644 --- a/content/renderer/gpu_channel_host.h +++ b/content/renderer/gpu_channel_host.h @@ -43,7 +43,7 @@ class GpuChannelHost : public IPC::Channel::Listener, // Called on the render thread GpuChannelHost(); - ~GpuChannelHost(); + virtual ~GpuChannelHost(); // Connect to GPU process channel. void Connect(const IPC::ChannelHandle& channel_handle, diff --git a/content/renderer/indexed_db_dispatcher.h b/content/renderer/indexed_db_dispatcher.h index b019510..8bd608e 100644 --- a/content/renderer/indexed_db_dispatcher.h +++ b/content/renderer/indexed_db_dispatcher.h @@ -28,7 +28,7 @@ class WebIDBTransaction; class IndexedDBDispatcher : public IPC::Channel::Listener { public: IndexedDBDispatcher(); - ~IndexedDBDispatcher(); + virtual ~IndexedDBDispatcher(); // IPC::Channel::Listener implementation. virtual bool OnMessageReceived(const IPC::Message& msg); diff --git a/content/renderer/plugin_channel_host.h b/content/renderer/plugin_channel_host.h index ec6bfed..524df47 100644 --- a/content/renderer/plugin_channel_host.h +++ b/content/renderer/plugin_channel_host.h @@ -46,7 +46,7 @@ class PluginChannelHost : public PluginChannelBase { private: // Called on the render thread PluginChannelHost(); - ~PluginChannelHost(); + virtual ~PluginChannelHost(); static PluginChannelBase* ClassFactory() { return new PluginChannelHost(); } diff --git a/content/renderer/render_process_impl.h b/content/renderer/render_process_impl.h index b530e6a..c5cbabe 100644 --- a/content/renderer/render_process_impl.h +++ b/content/renderer/render_process_impl.h @@ -20,7 +20,7 @@ class PlatformCanvas; class RenderProcessImpl : public RenderProcess { public: RenderProcessImpl(); - ~RenderProcessImpl(); + virtual ~RenderProcessImpl(); // RenderProcess implementation. virtual skia::PlatformCanvas* GetDrawingCanvas(TransportDIB** memory, diff --git a/content/renderer/renderer_webidbobjectstore_impl.h b/content/renderer/renderer_webidbobjectstore_impl.h index 802ba32..6467960 100644 --- a/content/renderer/renderer_webidbobjectstore_impl.h +++ b/content/renderer/renderer_webidbobjectstore_impl.h @@ -22,7 +22,7 @@ class WebString; class RendererWebIDBObjectStoreImpl : public WebKit::WebIDBObjectStore { public: explicit RendererWebIDBObjectStoreImpl(int32 idb_object_store_id); - ~RendererWebIDBObjectStoreImpl(); + virtual ~RendererWebIDBObjectStoreImpl(); // WebKit::WebIDBObjectStore virtual WebKit::WebString name() const; diff --git a/content/renderer/webplugin_delegate_proxy.h b/content/renderer/webplugin_delegate_proxy.h index 304e72b..7912436 100644 --- a/content/renderer/webplugin_delegate_proxy.h +++ b/content/renderer/webplugin_delegate_proxy.h @@ -123,7 +123,7 @@ class WebPluginDelegateProxy protected: template<class WebPluginDelegateProxy> friend class DeleteTask; - ~WebPluginDelegateProxy(); + virtual ~WebPluginDelegateProxy(); private: // Message handlers for messages that proxy WebPlugin methods, which diff --git a/content/renderer/webworker_proxy.h b/content/renderer/webworker_proxy.h index 9151193..80014ac 100644 --- a/content/renderer/webworker_proxy.h +++ b/content/renderer/webworker_proxy.h @@ -29,7 +29,7 @@ class WebWorkerProxy : public WebKit::WebWorker, private WebWorkerBase { ChildThread* child_thread, int render_view_route_id, int parent_appcache_host_id); - ~WebWorkerProxy(); + virtual ~WebWorkerProxy(); // WebWorker implementation. virtual void startWorkerContext(const WebKit::WebURL& script_url, |