Move ProvidePictureBuffers out of initialization and into the decode path.

This is required for various reasons:
- Clients don't necessarily know the dimensions of the video they feed to the
  decoder.  It's the decoder's job to figure it out from the encoded stream, but
  it only gets a crack at that once Decode() is called, after initialization is
  done.
- PPAPI plugins get to call PPB_* functions at will, which means that (to avoid
  having to code re-entrancy into everything on the browser side) PPB_*
  functions aren't allowed to call into PPP_* functions.  So the previous call
  sequence of Initialize->ProvidePictureBuffers->CreateTextures would deadlock
  (requiring plugins to pre-create any textures they were going to get asked for
  in the future).

Also a bit of minor cleanup & added TODOs for future cleanup, and changed
GetConfigs()' signature to match the PPAPI version of itself (return bool
instead of void).

BUG=none
TEST=OVDATest passes on kaen.

Review URL: http://codereview.chromium.org/7147006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89251 0039d316-1c4b-4281-b951-d872f2087c98

4 files changed, 6 insertions, 4 deletions

diff --git a/content/renderer/gpu/gpu_video_decode_accelerator_host.cc b/content/renderer/gpu/gpu_video_decode_accelerator_host.cc
index 8a03cda..4f08dab 100644
--- a/content/renderer/gpu/gpu_video_decode_accelerator_host.cc
+++ b/content/renderer/gpu/gpu_video_decode_accelerator_host.cc
@@ -65,11 +65,12 @@ bool GpuVideoDecodeAcceleratorHost::OnMessageReceived(const IPC::Message& msg) {
   return handled;
 }
 
-void GpuVideoDecodeAcceleratorHost::GetConfigs(
+bool GpuVideoDecodeAcceleratorHost::GetConfigs(
     const std::vector<uint32>& requested_configs,
     std::vector<uint32>* matched_configs) {
   // TODO(vrk): Need to rethink GetConfigs.
   NOTIMPLEMENTED();
+  return true;
 }
 
 bool GpuVideoDecodeAcceleratorHost::Initialize(
diff --git a/content/renderer/gpu/gpu_video_decode_accelerator_host.h b/content/renderer/gpu/gpu_video_decode_accelerator_host.h
index 8b4a4c3..ea73da0 100644
--- a/content/renderer/gpu/gpu_video_decode_accelerator_host.h
+++ b/content/renderer/gpu/gpu_video_decode_accelerator_host.h
@@ -35,7 +35,7 @@ class GpuVideoDecodeAcceleratorHost : public IPC::Channel::Listener,
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
 
   // media::VideoDecodeAccelerator implementation.
-  virtual void GetConfigs(
+  virtual bool GetConfigs(
       const std::vector<uint32>& requested_configs,
       std::vector<uint32>* matched_configs) OVERRIDE;
   virtual bool Initialize(const std::vector<uint32>& configs) OVERRIDE;
diff --git a/content/renderer/pepper_platform_video_decoder_impl.cc b/content/renderer/pepper_platform_video_decoder_impl.cc
index 27fd963..009571d 100644
--- a/content/renderer/pepper_platform_video_decoder_impl.cc
+++ b/content/renderer/pepper_platform_video_decoder_impl.cc
@@ -27,11 +27,12 @@ PlatformVideoDecoderImpl::PlatformVideoDecoderImpl(
 
 PlatformVideoDecoderImpl::~PlatformVideoDecoderImpl() {}
 
-void PlatformVideoDecoderImpl::GetConfigs(
+bool PlatformVideoDecoderImpl::GetConfigs(
     const std::vector<uint32>& requested_configs,
     std::vector<uint32>* matched_configs) {
   // TODO(vrk): Implement.
   NOTIMPLEMENTED();
+  return true;
 }
 
 bool PlatformVideoDecoderImpl::Initialize(const std::vector<uint32>& config) {
diff --git a/content/renderer/pepper_platform_video_decoder_impl.h b/content/renderer/pepper_platform_video_decoder_impl.h
index c119437..02ca25e 100644
--- a/content/renderer/pepper_platform_video_decoder_impl.h
+++ b/content/renderer/pepper_platform_video_decoder_impl.h
@@ -26,7 +26,7 @@ class PlatformVideoDecoderImpl
   virtual ~PlatformVideoDecoderImpl();
 
   // PlatformVideoDecoder implementation.
-  virtual void  GetConfigs(
+  virtual bool GetConfigs(
       const std::vector<uint32>& requested_configs,
       std::vector<uint32>* matched_configs) OVERRIDE;
   virtual bool Initialize(const std::vector<uint32>& config) OVERRIDE;