diff options
author | ariblue <ariblue@google.com> | 2014-11-06 13:52:54 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-11-06 21:53:20 +0000 |
commit | b6bad3dc24d88ba1ce182e7ab3fbe6e2e281c998 (patch) | |
tree | c188ba94bc8b311ec5f83dd543d2406de94a562c /content/shell/browser/shell_devtools_frontend.cc | |
parent | 66dc372e7e87901474963b5b9acd65ac854b56c3 (diff) | |
download | chromium_src-b6bad3dc24d88ba1ce182e7ab3fbe6e2e281c998.zip chromium_src-b6bad3dc24d88ba1ce182e7ab3fbe6e2e281c998.tar.gz chromium_src-b6bad3dc24d88ba1ce182e7ab3fbe6e2e281c998.tar.bz2 |
In https://codereview.chromium.org/651383002/ I created a generic output
directory for all output artifacts (html/json/etc results, profiler files,
etc). This reused the existing --output-dir flag used by the profile
generator.
The _SessionRestoreTest benchmark manually sets the output_dir in its
ProcessCommandLineArgs (PCLA) function. However, here is the hierarchy of
PCLA calls for run_benchmark (lower in the list happens later):
- benchmark
- page_runner
- page_filter
- results_options
- benchmark_class (_SessionRestoreTest)
In the results_options PCLA call, we ensure that the output_dir exists.
However, in the _SessionRestoreTest PCLA call we change the output_dir
(which now is guaranteed NOT to exist).
This patch creates the directory we are changing to in the
_SessionRestoreTest PCLA call instead.
BUG=430276
Review URL: https://codereview.chromium.org/706783002
Cr-Commit-Position: refs/heads/master@{#303094}
Diffstat (limited to 'content/shell/browser/shell_devtools_frontend.cc')
0 files changed, 0 insertions, 0 deletions