diff options
| author | grt@chromium.org <grt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-26 02:02:18 +0000 |
|---|---|---|
| committer | grt@chromium.org <grt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-05-26 02:02:18 +0000 |
| commit | e0185f9fe7ba991f701ac7bb6d8dbafa745a31ab (patch) | |
| tree | d43a5f87c837ba410e30e0d9095f1cd3e1a9c95c /content/shell/common | |
| parent | d70d82db35eecb586629a05bffc580282c0c30b4 (diff) | |
| download | chromium_src-e0185f9fe7ba991f701ac7bb6d8dbafa745a31ab.zip chromium_src-e0185f9fe7ba991f701ac7bb6d8dbafa745a31ab.tar.gz chromium_src-e0185f9fe7ba991f701ac7bb6d8dbafa745a31ab.tar.bz2 | |
Revert 202188 "Introduce content::PageState."
This change bloated npchrome_frame.dll (see
http://build.chromium.org/f/chromium/perf/xp-release/sizes/report.html?=undefined&history=3&rev=202214&graph=npchrome_frame.dll)
because content_common.lib's common_param_traits.obj depends on
content_common.lib's page_state.obj which, in turn, depends on
webkit. This means that consumers of IPC messages in content_common
suddenly require all of webkit.
> Introduce content::PageState.
>
> This is a concrete class wrapping a string that contains the
> data of a serialized WebKit::WebHistoryItem class. Previously,
> we've just passed around these as strings, giving them names
> like "state", "content_state" or "history_state". It has been
> hard to identify all of the places in the code where these
> strings get passed around. A concrete class should make usage
> more apparent. Plus, instead of manipulating the strings using
> methods from webkit/glue/glue_serialize.h, we can just declare
> methods on the PageState class. This makes the code much cleaner.
>
> This first pass just implements PageState in terms of glue_serialize.
> It also adds content/public/renderer/history_item_serialization.h
> as the home for PageState to WebKit::WebHistoryItem conversion,
> which should ideally only be usable from the renderer process.
> (This bit is a step toward resolving bug 237243.)
>
> page_state.h declares operator==() to support DCHECK_EQ, which
> seems consistent with the idea of PageState being a replacement
> for std::string. I didn't want to litter tests with calls to
> PageState::ToEncodedData(). That would get cumbersome.
>
> BUG=240426
> R=brettw@chromium.org, tsepez@chromium.org
>
> Review URL: https://codereview.chromium.org/14985014
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/16068002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202321 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'content/shell/common')
| -rw-r--r-- | content/shell/common/shell_messages.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/content/shell/common/shell_messages.h b/content/shell/common/shell_messages.h index df490b3..37d60e98 100644 --- a/content/shell/common/shell_messages.h +++ b/content/shell/common/shell_messages.h @@ -7,7 +7,6 @@ #include <vector> #include "content/public/common/common_param_traits.h" -#include "content/public/common/page_state.h" #include "content/shell/common/shell_test_configuration.h" #include "ipc/ipc_message_macros.h" #include "ipc/ipc_platform_file.h" @@ -52,7 +51,7 @@ IPC_MESSAGE_ROUTED0(ShellViewMsg_NotifyDone) IPC_MESSAGE_ROUTED3( ShellViewMsg_SessionHistory, std::vector<int> /* routing_ids */, - std::vector<std::vector<content::PageState> > /* session_histories */, + std::vector<std::vector<std::string> > /* session_histories */, std::vector<unsigned> /* current_entry_indexes */) // Send a text dump of the WebContents to the render host. |